Commit d791db9a authored by Arvind Yadav's avatar Arvind Yadav Committed by Darren Hart (VMware)

platform/x86: sony-laptop: constify attribute_group and input index array

attribute_groups are not supposed to change at runtime. All functions
working with attribute_groups provided by <linux/sysfs.h> work with const
attribute_group.

The content of sony_laptop_input_index does not change and is declared
as a static global array.

Constify spic_attribute_group and sony_laptop_input_index.

File size before:
   text	   data	    bss	    dec	    hex	filename
  31273	   5176	    372	  36821	   8fd5	drivers/platform/x86/sony-laptop.o

File size After adding 'const':
   text	   data	    bss	    dec	    hex	filename
  31337	   5112	    372	  36821	   8fd5	drivers/platform/x86/sony-laptop.o
Signed-off-by: default avatarArvind Yadav <arvind.yadav.cs@gmail.com>
[dvhart: updated commit message, includes fix suggested by Arnd Bergmann]
Signed-off-by: default avatarAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: default avatarDarren Hart (VMware) <dvhart@infradead.org>
parent eee77da1
...@@ -222,7 +222,7 @@ struct sony_laptop_keypress { ...@@ -222,7 +222,7 @@ struct sony_laptop_keypress {
/* Correspondance table between sonypi events /* Correspondance table between sonypi events
* and input layer indexes in the keymap * and input layer indexes in the keymap
*/ */
static int sony_laptop_input_index[] = { static const int sony_laptop_input_index[] = {
-1, /* 0 no event */ -1, /* 0 no event */
-1, /* 1 SONYPI_EVENT_JOGDIAL_DOWN */ -1, /* 1 SONYPI_EVENT_JOGDIAL_DOWN */
-1, /* 2 SONYPI_EVENT_JOGDIAL_UP */ -1, /* 2 SONYPI_EVENT_JOGDIAL_UP */
...@@ -4032,7 +4032,7 @@ static struct attribute *spic_attributes[] = { ...@@ -4032,7 +4032,7 @@ static struct attribute *spic_attributes[] = {
NULL NULL
}; };
static struct attribute_group spic_attribute_group = { static const struct attribute_group spic_attribute_group = {
.attrs = spic_attributes .attrs = spic_attributes
}; };
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment