Commit d7d75960 authored by Patrick Kelle's avatar Patrick Kelle Committed by David S. Miller

icplus: mdio_write(), remove unnecessary for loop

At this point the variable j is always set to 7 and the code within
the loop has to run only once anyway.

As suggested by David Miller:
"You can simply this even further since p[7] is what is used here,
and this means len is one, the inner loop therefore executes only
once, and the p[7].field value is not used (it's zero in the table)
and the write to it is completely thrown away."
Signed-off-by: default avatarPatrick Kelle <patrick.kelle81@gmail.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent b536db93
...@@ -371,16 +371,9 @@ static void mdio_write(struct net_device *dev, int phy_id, int phy_reg, int val) ...@@ -371,16 +371,9 @@ static void mdio_write(struct net_device *dev, int phy_id, int phy_reg, int val)
} }
/* The last cycle is a tri-state, so read from the PHY. */ /* The last cycle is a tri-state, so read from the PHY. */
for (j = 7; j < 8; j++) { ipg_write_phy_ctl(ioaddr, IPG_PC_MGMTCLK_LO | polarity);
for (i = 0; i < p[j].len; i++) { ipg_r8(PHY_CTRL);
ipg_write_phy_ctl(ioaddr, IPG_PC_MGMTCLK_LO | polarity); ipg_write_phy_ctl(ioaddr, IPG_PC_MGMTCLK_HI | polarity);
p[j].field |= ((ipg_r8(PHY_CTRL) &
IPG_PC_MGMTDATA) >> 1) << (p[j].len - 1 - i);
ipg_write_phy_ctl(ioaddr, IPG_PC_MGMTCLK_HI | polarity);
}
}
} }
static void ipg_set_led_mode(struct net_device *dev) static void ipg_set_led_mode(struct net_device *dev)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment