Commit d7eb6512 authored by Dan Carpenter's avatar Dan Carpenter Committed by David S. Miller

of: mdio: Fix a signedness bug in of_phy_get_and_connect()

The "iface" variable is an enum and in this context GCC treats it as
an unsigned int so the error handling is never triggered.

Fixes: b7862412 ("of_mdio: Abstract a general interface for phy connect")
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 73e211e1
...@@ -362,7 +362,7 @@ struct phy_device *of_phy_get_and_connect(struct net_device *dev, ...@@ -362,7 +362,7 @@ struct phy_device *of_phy_get_and_connect(struct net_device *dev,
int ret; int ret;
iface = of_get_phy_mode(np); iface = of_get_phy_mode(np);
if (iface < 0) if ((int)iface < 0)
return NULL; return NULL;
if (of_phy_is_fixed_link(np)) { if (of_phy_is_fixed_link(np)) {
ret = of_phy_register_fixed_link(np); ret = of_phy_register_fixed_link(np);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment