Commit d7ef875d authored by Julia Lawall's avatar Julia Lawall Committed by Jiri Slaby

NFC: pn533: fix error return code

commit 5df848f3 upstream.

Return a negative error code on failure.

A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)

// <smpl>
@@
identifier ret; expression e1,e2;
@@
(
if (\(ret < 0\|ret != 0\))
 { ... return ret; }
|
ret = 0
)
... when != ret = e1
    when != &ret
*if(...)
{
  ... when != ret = e2
      when forall
 return ret;
}
// </smpl>
Signed-off-by: default avatarJulia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: default avatarSamuel Ortiz <sameo@linux.intel.com>
Signed-off-by: default avatarJiri Slaby <jslaby@suse.cz>
parent fd4420ab
...@@ -2352,8 +2352,10 @@ static int pn533_data_exchange_complete(struct pn533 *dev, void *_arg, ...@@ -2352,8 +2352,10 @@ static int pn533_data_exchange_complete(struct pn533 *dev, void *_arg,
} }
skb = pn533_build_response(dev); skb = pn533_build_response(dev);
if (!skb) if (!skb) {
rc = -ENOMEM;
goto error; goto error;
}
arg->cb(arg->cb_context, skb, 0); arg->cb(arg->cb_context, skb, 0);
kfree(arg); kfree(arg);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment