Commit d8991f51 authored by Joel Fernandes's avatar Joel Fernandes Committed by Kees Cook

pstore: Warn on PSTORE_TYPE_PMSG using deprecated function

PMSG now uses ramoops_pstore_write_buf_user() instead of ...write_buf().
Print a ratelimited warning if gets accidentally called.
Signed-off-by: default avatarJoel Fernandes <joelaf@google.com>
[kees: adjusted commit log and added -EINVAL return]
Signed-off-by: default avatarKees Cook <keescook@chromium.org>
parent 10970449
...@@ -288,10 +288,8 @@ static int notrace ramoops_pstore_write_buf(enum pstore_type_id type, ...@@ -288,10 +288,8 @@ static int notrace ramoops_pstore_write_buf(enum pstore_type_id type,
persistent_ram_write(cxt->fprz, buf, size); persistent_ram_write(cxt->fprz, buf, size);
return 0; return 0;
} else if (type == PSTORE_TYPE_PMSG) { } else if (type == PSTORE_TYPE_PMSG) {
if (!cxt->mprz) pr_warn_ratelimited("PMSG shouldn't call %s\n", __func__);
return -ENOMEM; return -EINVAL;
persistent_ram_write(cxt->mprz, buf, size);
return 0;
} }
if (type != PSTORE_TYPE_DMESG) if (type != PSTORE_TYPE_DMESG)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment