Commit d8fc3afc authored by Tejun Heo's avatar Tejun Heo

x86, NUMA: Move *_numa_init() invocations into initmem_init()

There's no reason for these to live in setup_arch().  Move them inside
initmem_init().

- v2: x86-32 initmem_init() weren't updated breaking 32bit builds.
  Fixed.  Found by Ankita.
Signed-off-by: default avatarTejun Heo <tj@kernel.org>
Cc: Ankita Garg <ankita@in.ibm.com>
Cc: Yinghai Lu <yinghai@kernel.org>
Cc: Brian Gerst <brgerst@gmail.com>
Cc: Cyrill Gorcunov <gorcunov@gmail.com>
Cc: Shaohui Zheng <shaohui.zheng@intel.com>
Cc: David Rientjes <rientjes@google.com>
Cc: Ingo Molnar <mingo@elte.hu>
Cc: H. Peter Anvin <hpa@linux.intel.com>
parent a9aec56a
...@@ -56,7 +56,7 @@ extern unsigned long init_memory_mapping(unsigned long start, ...@@ -56,7 +56,7 @@ extern unsigned long init_memory_mapping(unsigned long start,
void init_memory_mapping_high(void); void init_memory_mapping_high(void);
extern void initmem_init(int acpi, int k8); extern void initmem_init(void);
extern void free_initmem(void); extern void free_initmem(void);
#endif /* !__ASSEMBLY__ */ #endif /* !__ASSEMBLY__ */
......
...@@ -719,8 +719,6 @@ early_param("reservelow", parse_reservelow); ...@@ -719,8 +719,6 @@ early_param("reservelow", parse_reservelow);
void __init setup_arch(char **cmdline_p) void __init setup_arch(char **cmdline_p)
{ {
int acpi = 0;
int amd = 0;
unsigned long flags; unsigned long flags;
#ifdef CONFIG_X86_32 #ifdef CONFIG_X86_32
...@@ -991,19 +989,7 @@ void __init setup_arch(char **cmdline_p) ...@@ -991,19 +989,7 @@ void __init setup_arch(char **cmdline_p)
early_acpi_boot_init(); early_acpi_boot_init();
#ifdef CONFIG_ACPI_NUMA initmem_init();
/*
* Parse SRAT to discover nodes.
*/
acpi = !x86_acpi_numa_init();
#endif
#ifdef CONFIG_AMD_NUMA
if (!acpi)
amd = !amd_numa_init();
#endif
initmem_init(acpi, amd);
memblock_find_dma_reserve(); memblock_find_dma_reserve();
dma32_reserve_bootmem(); dma32_reserve_bootmem();
......
...@@ -644,7 +644,7 @@ void __init find_low_pfn_range(void) ...@@ -644,7 +644,7 @@ void __init find_low_pfn_range(void)
} }
#ifndef CONFIG_NEED_MULTIPLE_NODES #ifndef CONFIG_NEED_MULTIPLE_NODES
void __init initmem_init(int acpi, int k8) void __init initmem_init(void)
{ {
#ifdef CONFIG_HIGHMEM #ifdef CONFIG_HIGHMEM
highstart_pfn = highend_pfn = max_pfn; highstart_pfn = highend_pfn = max_pfn;
......
...@@ -603,7 +603,7 @@ kernel_physical_mapping_init(unsigned long start, ...@@ -603,7 +603,7 @@ kernel_physical_mapping_init(unsigned long start,
} }
#ifndef CONFIG_NUMA #ifndef CONFIG_NUMA
void __init initmem_init(int acpi, int k8) void __init initmem_init(void)
{ {
memblock_x86_register_active_regions(0, 0, max_pfn); memblock_x86_register_active_regions(0, 0, max_pfn);
init_memory_mapping_high(); init_memory_mapping_high();
......
...@@ -352,7 +352,7 @@ static void init_remap_allocator(int nid) ...@@ -352,7 +352,7 @@ static void init_remap_allocator(int nid)
(ulong) node_remap_end_vaddr[nid]); (ulong) node_remap_end_vaddr[nid]);
} }
void __init initmem_init(int acpi, int k8) void __init initmem_init(void)
{ {
int nid; int nid;
long kva_target_pfn; long kva_target_pfn;
......
...@@ -13,6 +13,7 @@ ...@@ -13,6 +13,7 @@
#include <linux/module.h> #include <linux/module.h>
#include <linux/nodemask.h> #include <linux/nodemask.h>
#include <linux/sched.h> #include <linux/sched.h>
#include <linux/acpi.h>
#include <asm/e820.h> #include <asm/e820.h>
#include <asm/proto.h> #include <asm/proto.h>
...@@ -579,10 +580,23 @@ static int __init numa_emulation(unsigned long start_pfn, ...@@ -579,10 +580,23 @@ static int __init numa_emulation(unsigned long start_pfn,
} }
#endif /* CONFIG_NUMA_EMU */ #endif /* CONFIG_NUMA_EMU */
void __init initmem_init(int acpi, int amd) void __init initmem_init(void)
{ {
int acpi = 0, amd = 0;
int i; int i;
#ifdef CONFIG_ACPI_NUMA
/*
* Parse SRAT to discover nodes.
*/
acpi = !x86_acpi_numa_init();
#endif
#ifdef CONFIG_AMD_NUMA
if (!acpi)
amd = !amd_numa_init();
#endif
nodes_clear(node_possible_map); nodes_clear(node_possible_map);
nodes_clear(node_online_map); nodes_clear(node_online_map);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment