Commit d9a9280a authored by Arnd Bergmann's avatar Arnd Bergmann Committed by Steven Rostedt (VMware)

seq_buf: Avoid type mismatch for seq_buf_init

Building with W=2 prints a number of warnings for one function that
has a pointer type mismatch:

linux/seq_buf.h: In function 'seq_buf_init':
linux/seq_buf.h:35:12: warning: pointer targets in assignment from 'unsigned char *' to 'char *' differ in signedness [-Wpointer-sign]

Change the type in the function prototype according to the type in
the structure.

Link: https://lkml.kernel.org/r/20201026161108.3707783-1-arnd@kernel.org

Fixes: 9a777793 ("tracing: Convert seq_buf fields to be like seq_file fields")
Reviewed-by: default avatarCezary Rojewski <cezary.rojewski@intel.com>
Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
Signed-off-by: default avatarSteven Rostedt (VMware) <rostedt@goodmis.org>
parent 88883490
...@@ -30,7 +30,7 @@ static inline void seq_buf_clear(struct seq_buf *s) ...@@ -30,7 +30,7 @@ static inline void seq_buf_clear(struct seq_buf *s)
} }
static inline void static inline void
seq_buf_init(struct seq_buf *s, unsigned char *buf, unsigned int size) seq_buf_init(struct seq_buf *s, char *buf, unsigned int size)
{ {
s->buffer = buf; s->buffer = buf;
s->size = size; s->size = size;
......
...@@ -12,7 +12,7 @@ ...@@ -12,7 +12,7 @@
*/ */
struct trace_seq { struct trace_seq {
unsigned char buffer[PAGE_SIZE]; char buffer[PAGE_SIZE];
struct seq_buf seq; struct seq_buf seq;
int full; int full;
}; };
...@@ -51,7 +51,7 @@ static inline int trace_seq_used(struct trace_seq *s) ...@@ -51,7 +51,7 @@ static inline int trace_seq_used(struct trace_seq *s)
* that is about to be written to and then return the result * that is about to be written to and then return the result
* of that write. * of that write.
*/ */
static inline unsigned char * static inline char *
trace_seq_buffer_ptr(struct trace_seq *s) trace_seq_buffer_ptr(struct trace_seq *s)
{ {
return s->buffer + seq_buf_used(&s->seq); return s->buffer + seq_buf_used(&s->seq);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment