Commit d9c0b48d authored by Quentin Monnet's avatar Quentin Monnet Committed by David S. Miller

tools: bpftool: print only one error message on byte parsing failure

Make error messages more consistent. Specifically, when bpftool fails at
parsing map key bytes, make it print a single error message to stderr
and return from the function, instead of (always) printing a second
error message afterwards.
Signed-off-by: default avatarQuentin Monnet <quentin.monnet@netronome.com>
Signed-off-by: default avatarJakub Kicinski <jakub.kicinski@netronome.com>
Acked-by: default avatarDaniel Borkmann <daniel@iogearbox.net>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 9f606179
...@@ -252,7 +252,7 @@ static char **parse_bytes(char **argv, const char *name, unsigned char *val, ...@@ -252,7 +252,7 @@ static char **parse_bytes(char **argv, const char *name, unsigned char *val,
val[i] = strtoul(argv[i], &endptr, 0); val[i] = strtoul(argv[i], &endptr, 0);
if (*endptr) { if (*endptr) {
err("error parsing byte: %s\n", argv[i]); err("error parsing byte: %s\n", argv[i]);
break; return NULL;
} }
i++; i++;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment