Commit d9ca7280 authored by Russell King (Oracle)'s avatar Russell King (Oracle) Committed by David S. Miller

net: mvneta: remove interface checks in mvneta_validate()

As phylink checks the interface mode against the supported_interfaces
bitmap, we no longer need to validate the interface mode in the
validation function. Remove this to simplify it.
Signed-off-by: default avatarRussell King (Oracle) <rmk+kernel@armlinux.org.uk>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent fdedb695
...@@ -3832,15 +3832,8 @@ static void mvneta_validate(struct phylink_config *config, ...@@ -3832,15 +3832,8 @@ static void mvneta_validate(struct phylink_config *config,
* "Bit 2 Field InBandAnEn In-band Auto-Negotiation enable. ... * "Bit 2 Field InBandAnEn In-band Auto-Negotiation enable. ...
* When <PortType> = 1 (1000BASE-X) this field must be set to 1." * When <PortType> = 1 (1000BASE-X) this field must be set to 1."
*/ */
if (phy_interface_mode_is_8023z(state->interface)) { if (phy_interface_mode_is_8023z(state->interface) &&
if (!phylink_test(state->advertising, Autoneg)) { !phylink_test(state->advertising, Autoneg)) {
linkmode_zero(supported);
return;
}
} else if (state->interface != PHY_INTERFACE_MODE_NA &&
state->interface != PHY_INTERFACE_MODE_QSGMII &&
state->interface != PHY_INTERFACE_MODE_SGMII &&
!phy_interface_mode_is_rgmii(state->interface)) {
linkmode_zero(supported); linkmode_zero(supported);
return; return;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment