Commit dae1d8ac authored by Cristian Marussi's avatar Cristian Marussi Committed by Shuah Khan

selftests: skip mincore.check_file_mmap when fs lacks needed support

Report mincore.check_file_mmap as SKIP instead of FAIL if the underlying
filesystem lacks support of O_TMPFILE or fallocate since such failures
are not really related to mincore functionality.

Cc: Ricardo Cañuelo <ricardo.canuelo@collabora.com>
Signed-off-by: default avatarCristian Marussi <cristian.marussi@arm.com>
Signed-off-by: default avatarShuah Khan <skhan@linuxfoundation.org>
parent ac9e0a25
...@@ -207,15 +207,21 @@ TEST(check_file_mmap) ...@@ -207,15 +207,21 @@ TEST(check_file_mmap)
errno = 0; errno = 0;
fd = open(".", O_TMPFILE | O_RDWR, 0600); fd = open(".", O_TMPFILE | O_RDWR, 0600);
ASSERT_NE(-1, fd) { if (fd < 0) {
TH_LOG("Can't create temporary file: %s", ASSERT_EQ(errno, EOPNOTSUPP) {
strerror(errno)); TH_LOG("Can't create temporary file: %s",
strerror(errno));
}
SKIP(goto out_free, "O_TMPFILE not supported by filesystem.");
} }
errno = 0; errno = 0;
retval = fallocate(fd, 0, 0, FILE_SIZE); retval = fallocate(fd, 0, 0, FILE_SIZE);
ASSERT_EQ(0, retval) { if (retval) {
TH_LOG("Error allocating space for the temporary file: %s", ASSERT_EQ(errno, EOPNOTSUPP) {
strerror(errno)); TH_LOG("Error allocating space for the temporary file: %s",
strerror(errno));
}
SKIP(goto out_close, "fallocate not supported by filesystem.");
} }
/* /*
...@@ -271,7 +277,9 @@ TEST(check_file_mmap) ...@@ -271,7 +277,9 @@ TEST(check_file_mmap)
} }
munmap(addr, FILE_SIZE); munmap(addr, FILE_SIZE);
out_close:
close(fd); close(fd);
out_free:
free(vec); free(vec);
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment