Commit dc2733de authored by Miquel Raynal's avatar Miquel Raynal

mtd: rawnand: nandsim: Fix the label pointing on nand_cleanup()

Drop the generic err_exit.

The remaining operation to do from this goto statement is to cleanup
the NAND allocations, so rename it.
Signed-off-by: default avatarMiquel Raynal <miquel.raynal@bootlin.com>
Link: https://lore.kernel.org/linux-mtd/20200525085851.17682-15-miquel.raynal@bootlin.com
parent 5dcb5164
...@@ -2366,7 +2366,7 @@ static int __init ns_init_module(void) ...@@ -2366,7 +2366,7 @@ static int __init ns_init_module(void)
if (new_size >> overridesize != nsmtd->erasesize) { if (new_size >> overridesize != nsmtd->erasesize) {
NS_ERR("overridesize is too big\n"); NS_ERR("overridesize is too big\n");
ret = -EINVAL; ret = -EINVAL;
goto err_exit; goto cleanup_nand;
} }
/* N.B. This relies on nand_scan not doing anything with the size before we change it */ /* N.B. This relies on nand_scan not doing anything with the size before we change it */
...@@ -2379,7 +2379,7 @@ static int __init ns_init_module(void) ...@@ -2379,7 +2379,7 @@ static int __init ns_init_module(void)
ret = ns_setup_wear_reporting(nsmtd); ret = ns_setup_wear_reporting(nsmtd);
if (ret) if (ret)
goto err_exit; goto cleanup_nand;
ret = ns_init(nsmtd); ret = ns_init(nsmtd);
if (ret) if (ret)
...@@ -2406,11 +2406,11 @@ static int __init ns_init_module(void) ...@@ -2406,11 +2406,11 @@ static int __init ns_init_module(void)
unregister_mtd: unregister_mtd:
WARN_ON(mtd_device_unregister(nsmtd)); WARN_ON(mtd_device_unregister(nsmtd));
err_exit:
free_ns_object: free_ns_object:
ns_free(ns); ns_free(ns);
free_ebw: free_ebw:
kfree(erase_block_wear); kfree(erase_block_wear);
cleanup_nand:
nand_cleanup(chip); nand_cleanup(chip);
error: error:
kfree(ns); kfree(ns);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment