Commit dc2f7271 authored by Johan Hovold's avatar Johan Hovold Committed by Greg Kroah-Hartman

serial: rate limit custom-speed deprecation notice

Contrary to what a comment claimed, the ASYNC_SPD flags and custom
divisor can be set by a non-privileged user so rate limit the
deprecation notice as was intended.
Signed-off-by: default avatarJohan Hovold <johan@kernel.org>
Reviewed-by: default avatarAndy Shevchenko <andy.shevchenko@gmail.com>
Reviewed-by: default avatarAlan Cox <alan@linux.intel.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 54ebbfb1
...@@ -954,11 +954,10 @@ static int uart_set_info(struct tty_struct *tty, struct tty_port *port, ...@@ -954,11 +954,10 @@ static int uart_set_info(struct tty_struct *tty, struct tty_port *port,
old_custom_divisor != uport->custom_divisor) { old_custom_divisor != uport->custom_divisor) {
/* /*
* If they're setting up a custom divisor or speed, * If they're setting up a custom divisor or speed,
* instead of clearing it, then bitch about it. No * instead of clearing it, then bitch about it.
* need to rate-limit; it's CAP_SYS_ADMIN only.
*/ */
if (uport->flags & UPF_SPD_MASK) { if (uport->flags & UPF_SPD_MASK) {
dev_notice(uport->dev, dev_notice_ratelimited(uport->dev,
"%s sets custom speed on %s. This is deprecated.\n", "%s sets custom speed on %s. This is deprecated.\n",
current->comm, current->comm,
tty_name(port->tty)); tty_name(port->tty));
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment