Commit dc66fe43 authored by Gustavo A. R. Silva's avatar Gustavo A. R. Silva Committed by David S. Miller

rds: send: Fix dead code in rds_sendmsg

Currently, code at label *out* is unreachable. Fix this by updating
variable *ret* with -EINVAL, so the jump to *out* can be properly
executed instead of directly returning from function.

Addresses-Coverity-ID: 1472059 ("Structurally dead code")
Fixes: 1e2b44e7 ("rds: Enable RDS IPv6 support")
Signed-off-by: default avatarGustavo A. R. Silva <gustavo@embeddedor.com>
Acked-by: default avatarSowmini Varadhan <sowmini.varadhan@oracle.com>
Acked-by: default avatarSantosh Shilimkar <santosh.shilimkar@oracle.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent ba7d7e26
...@@ -1126,7 +1126,7 @@ int rds_sendmsg(struct socket *sock, struct msghdr *msg, size_t payload_len) ...@@ -1126,7 +1126,7 @@ int rds_sendmsg(struct socket *sock, struct msghdr *msg, size_t payload_len)
if (addr4 == htonl(INADDR_ANY) || if (addr4 == htonl(INADDR_ANY) ||
addr4 == htonl(INADDR_BROADCAST) || addr4 == htonl(INADDR_BROADCAST) ||
IN_MULTICAST(ntohl(addr4))) { IN_MULTICAST(ntohl(addr4))) {
return -EINVAL; ret = -EINVAL;
goto out; goto out;
} }
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment