Commit dcd18a3f authored by Jinjie Ruan's avatar Jinjie Ruan Committed by Dmitry Torokhov

Input: ps2-gpio - use IRQF_NO_AUTOEN flag in request_irq()

disable_irq() after request_irq() still has a time gap in which
interrupts can come. request_irq() with IRQF_NO_AUTOEN flag will
disable IRQ auto-enable when request IRQ.

Fixes: 9ee0a055 ("Input: PS/2 gpio bit banging driver for serio bus")
Signed-off-by: default avatarJinjie Ruan <ruanjinjie@huawei.com>
Acked-by: default avatarDanilo Krummrich <dakr@kernel.org>
Link: https://lore.kernel.org/r/20240912033013.2610949-1-ruanjinjie@huawei.comSigned-off-by: default avatarDmitry Torokhov <dmitry.torokhov@gmail.com>
parent 82abef59
...@@ -429,16 +429,14 @@ static int ps2_gpio_probe(struct platform_device *pdev) ...@@ -429,16 +429,14 @@ static int ps2_gpio_probe(struct platform_device *pdev)
} }
error = devm_request_irq(dev, drvdata->irq, ps2_gpio_irq, error = devm_request_irq(dev, drvdata->irq, ps2_gpio_irq,
IRQF_NO_THREAD, DRIVER_NAME, drvdata); IRQF_NO_THREAD | IRQF_NO_AUTOEN, DRIVER_NAME,
drvdata);
if (error) { if (error) {
dev_err(dev, "failed to request irq %d: %d\n", dev_err(dev, "failed to request irq %d: %d\n",
drvdata->irq, error); drvdata->irq, error);
goto err_free_serio; goto err_free_serio;
} }
/* Keep irq disabled until serio->open is called. */
disable_irq(drvdata->irq);
serio->id.type = SERIO_8042; serio->id.type = SERIO_8042;
serio->open = ps2_gpio_open; serio->open = ps2_gpio_open;
serio->close = ps2_gpio_close; serio->close = ps2_gpio_close;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment