Commit dce22df1 authored by Jean Delvare's avatar Jean Delvare Committed by Greg Kroah-Hartman

serial: 8250_lpss: make option visible

Hiding tristate options with "if EXPERT" is usually not a good idea.
You can decide that the driver should be included by default, but you
don't know if the user wants it built-in or as a module. Hiding the
option prevents the user from making that decision.

This is even more problematic when said option selects other options.
You end up with several device drivers forcibly built into the kernel.

In this specific case, drivers 8250_lpss, dw_dmac_core and
dw_dmac_pci end up being built-in as soon as SERIAL_8250=y. It is
very common for distribution kernels to build the subsystem core code
into the kernel, because almost everybody will need it, but build all
the device drivers as modules. This should be made possible.

So drop the "if EXPERT" and make SERIAL_8250_LPSS visible.
Signed-off-by: default avatarJean Delvare <jdelvare@suse.de>
Fixes: a13e19cf ("serial: 8250_lpss: split LPSS driver to separate module")
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Jiri Slaby <jslaby@suse.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent f1e8c710
...@@ -402,7 +402,7 @@ config SERIAL_8250_INGENIC ...@@ -402,7 +402,7 @@ config SERIAL_8250_INGENIC
its UARTs, say Y to this option. If unsure, say N. its UARTs, say Y to this option. If unsure, say N.
config SERIAL_8250_LPSS config SERIAL_8250_LPSS
tristate "Support for serial ports on Intel LPSS platforms" if EXPERT tristate "Support for serial ports on Intel LPSS platforms"
default SERIAL_8250 default SERIAL_8250
depends on SERIAL_8250 && PCI depends on SERIAL_8250 && PCI
depends on X86 || COMPILE_TEST depends on X86 || COMPILE_TEST
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment