Commit dd024130 authored by Guenter Roeck's avatar Guenter Roeck Committed by Luis Henriques

hwmon: (nct6775) Add missing sysfs attribute initialization

commit 1b63bf61 upstream.

The following error message is seen when loading the nct6775 driver
with DEBUG_LOCK_ALLOC enabled.

BUG: key ffff88040b2f0030 not in .data!
------------[ cut here ]------------
WARNING: CPU: 0 PID: 186 at kernel/locking/lockdep.c:2988
				lockdep_init_map+0x469/0x630()
DEBUG_LOCKS_WARN_ON(1)

Caused by a missing call to sysfs_attr_init() when initializing
sysfs attributes.
Reported-by: default avatarAlexey Orishko <alexey.orishko@gmail.com>
Reviewed-by: default avatarJean Delvare <jdelvare@suse.de>
Signed-off-by: default avatarGuenter Roeck <linux@roeck-us.net>
Signed-off-by: default avatarLuis Henriques <luis.henriques@canonical.com>
parent f71e478d
...@@ -986,6 +986,7 @@ nct6775_create_attr_group(struct device *dev, struct sensor_template_group *tg, ...@@ -986,6 +986,7 @@ nct6775_create_attr_group(struct device *dev, struct sensor_template_group *tg,
(*t)->dev_attr.attr.name, tg->base + i); (*t)->dev_attr.attr.name, tg->base + i);
if ((*t)->s2) { if ((*t)->s2) {
a2 = &su->u.a2; a2 = &su->u.a2;
sysfs_attr_init(&a2->dev_attr.attr);
a2->dev_attr.attr.name = su->name; a2->dev_attr.attr.name = su->name;
a2->nr = (*t)->u.s.nr + i; a2->nr = (*t)->u.s.nr + i;
a2->index = (*t)->u.s.index; a2->index = (*t)->u.s.index;
...@@ -996,6 +997,7 @@ nct6775_create_attr_group(struct device *dev, struct sensor_template_group *tg, ...@@ -996,6 +997,7 @@ nct6775_create_attr_group(struct device *dev, struct sensor_template_group *tg,
*attrs = &a2->dev_attr.attr; *attrs = &a2->dev_attr.attr;
} else { } else {
a = &su->u.a1; a = &su->u.a1;
sysfs_attr_init(&a->dev_attr.attr);
a->dev_attr.attr.name = su->name; a->dev_attr.attr.name = su->name;
a->index = (*t)->u.index + i; a->index = (*t)->u.index + i;
a->dev_attr.attr.mode = a->dev_attr.attr.mode =
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment