Commit dd40e456 authored by FUJITA Tomonori's avatar FUJITA Tomonori Committed by Jens Axboe

virtio_blk: stop using q->prepare_flush_fn

use REQ_FLUSH flag instead.
Signed-off-by: default avatarFUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
Cc: Rusty Russell <rusty@rustcorp.com.au>
Reviewed-by: default avatarChristoph Hellwig <hch@lst.de>
Signed-off-by: default avatarJens Axboe <jaxboe@fusionio.com>
parent 144d6ed5
...@@ -99,33 +99,32 @@ static bool do_req(struct request_queue *q, struct virtio_blk *vblk, ...@@ -99,33 +99,32 @@ static bool do_req(struct request_queue *q, struct virtio_blk *vblk,
return false; return false;
vbr->req = req; vbr->req = req;
switch (req->cmd_type) {
case REQ_TYPE_FS: if (req->cmd_flags & REQ_FLUSH) {
vbr->out_hdr.type = 0; vbr->out_hdr.type = VIRTIO_BLK_T_FLUSH;
vbr->out_hdr.sector = blk_rq_pos(vbr->req);
vbr->out_hdr.ioprio = req_get_ioprio(vbr->req);
break;
case REQ_TYPE_BLOCK_PC:
vbr->out_hdr.type = VIRTIO_BLK_T_SCSI_CMD;
vbr->out_hdr.sector = 0;
vbr->out_hdr.ioprio = req_get_ioprio(vbr->req);
break;
case REQ_TYPE_SPECIAL:
vbr->out_hdr.type = VIRTIO_BLK_T_GET_ID;
vbr->out_hdr.sector = 0; vbr->out_hdr.sector = 0;
vbr->out_hdr.ioprio = req_get_ioprio(vbr->req); vbr->out_hdr.ioprio = req_get_ioprio(vbr->req);
break; } else {
case REQ_TYPE_LINUX_BLOCK: switch (req->cmd_type) {
if (req->cmd[0] == REQ_LB_OP_FLUSH) { case REQ_TYPE_FS:
vbr->out_hdr.type = VIRTIO_BLK_T_FLUSH; vbr->out_hdr.type = 0;
vbr->out_hdr.sector = blk_rq_pos(vbr->req);
vbr->out_hdr.ioprio = req_get_ioprio(vbr->req);
break;
case REQ_TYPE_BLOCK_PC:
vbr->out_hdr.type = VIRTIO_BLK_T_SCSI_CMD;
vbr->out_hdr.sector = 0; vbr->out_hdr.sector = 0;
vbr->out_hdr.ioprio = req_get_ioprio(vbr->req); vbr->out_hdr.ioprio = req_get_ioprio(vbr->req);
break; break;
case REQ_TYPE_SPECIAL:
vbr->out_hdr.type = VIRTIO_BLK_T_GET_ID;
vbr->out_hdr.sector = 0;
vbr->out_hdr.ioprio = req_get_ioprio(vbr->req);
break;
default:
/* We don't put anything else in the queue. */
BUG();
} }
/*FALLTHRU*/
default:
/* We don't put anything else in the queue. */
BUG();
} }
if (vbr->req->cmd_flags & REQ_HARDBARRIER) if (vbr->req->cmd_flags & REQ_HARDBARRIER)
...@@ -195,12 +194,6 @@ static void do_virtblk_request(struct request_queue *q) ...@@ -195,12 +194,6 @@ static void do_virtblk_request(struct request_queue *q)
virtqueue_kick(vblk->vq); virtqueue_kick(vblk->vq);
} }
static void virtblk_prepare_flush(struct request_queue *q, struct request *req)
{
req->cmd_type = REQ_TYPE_LINUX_BLOCK;
req->cmd[0] = REQ_LB_OP_FLUSH;
}
/* return id (s/n) string for *disk to *id_str /* return id (s/n) string for *disk to *id_str
*/ */
static int virtblk_get_id(struct gendisk *disk, char *id_str) static int virtblk_get_id(struct gendisk *disk, char *id_str)
...@@ -373,8 +366,7 @@ static int __devinit virtblk_probe(struct virtio_device *vdev) ...@@ -373,8 +366,7 @@ static int __devinit virtblk_probe(struct virtio_device *vdev)
/* If barriers are supported, tell block layer that queue is ordered */ /* If barriers are supported, tell block layer that queue is ordered */
if (virtio_has_feature(vdev, VIRTIO_BLK_F_FLUSH)) if (virtio_has_feature(vdev, VIRTIO_BLK_F_FLUSH))
blk_queue_ordered(q, QUEUE_ORDERED_DRAIN_FLUSH, blk_queue_ordered(q, QUEUE_ORDERED_DRAIN_FLUSH, NULL);
virtblk_prepare_flush);
else if (virtio_has_feature(vdev, VIRTIO_BLK_F_BARRIER)) else if (virtio_has_feature(vdev, VIRTIO_BLK_F_BARRIER))
blk_queue_ordered(q, QUEUE_ORDERED_TAG, NULL); blk_queue_ordered(q, QUEUE_ORDERED_TAG, NULL);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment