Commit dd489240 authored by Paolo Bonzini's avatar Paolo Bonzini

KVM: document memory barriers for kvm->vcpus/kvm->online_vcpus

Signed-off-by: default avatarPaolo Bonzini <pbonzini@redhat.com>
parent c847fe88
...@@ -427,6 +427,10 @@ struct kvm { ...@@ -427,6 +427,10 @@ struct kvm {
static inline struct kvm_vcpu *kvm_get_vcpu(struct kvm *kvm, int i) static inline struct kvm_vcpu *kvm_get_vcpu(struct kvm *kvm, int i)
{ {
/* Pairs with smp_wmb() in kvm_vm_ioctl_create_vcpu, in case
* the caller has read kvm->online_vcpus before (as is the case
* for kvm_for_each_vcpu, for example).
*/
smp_rmb(); smp_rmb();
return kvm->vcpus[i]; return kvm->vcpus[i];
} }
......
...@@ -2206,6 +2206,11 @@ static int kvm_vm_ioctl_create_vcpu(struct kvm *kvm, u32 id) ...@@ -2206,6 +2206,11 @@ static int kvm_vm_ioctl_create_vcpu(struct kvm *kvm, u32 id)
} }
kvm->vcpus[atomic_read(&kvm->online_vcpus)] = vcpu; kvm->vcpus[atomic_read(&kvm->online_vcpus)] = vcpu;
/*
* Pairs with smp_rmb() in kvm_get_vcpu. Write kvm->vcpus
* before kvm->online_vcpu's incremented value.
*/
smp_wmb(); smp_wmb();
atomic_inc(&kvm->online_vcpus); atomic_inc(&kvm->online_vcpus);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment