Commit dd4b857a authored by Wang Xiaoguang's avatar Wang Xiaoguang Committed by David Sterba

btrfs: pass correct args to btrfs_async_run_delayed_refs()

In btrfs_truncate_inode_items()->btrfs_async_run_delayed_refs(), we
swap the arg2 and arg3 wrongly, fix this.

This bug just impacts asynchronous delayed refs handle when we truncate inodes.
In delayed_ref_async_start(), there is such codes:

    trans = btrfs_join_transaction(async->root);
    if (trans->transid > async->transid)
        goto end;
    ret = btrfs_run_delayed_refs(trans, async->root, async->count);

From this codes, we can see that this just influence whether can we handle
delayed refs or the number of delayed refs to handle, this may impact
performance, but will not result in missing delayed refs, all delayed refs will
be handled in btrfs_commit_transaction().
Signed-off-by: default avatarWang Xiaoguang <wangxg.fnst@cn.fujitsu.com>
Reviewed-by: default avatarHolger Hoffstätte <holger@applied-asynchrony.com>
Signed-off-by: default avatarDavid Sterba <dsterba@suse.com>
parent 69ae5e44
...@@ -4605,8 +4605,8 @@ int btrfs_truncate_inode_items(struct btrfs_trans_handle *trans, ...@@ -4605,8 +4605,8 @@ int btrfs_truncate_inode_items(struct btrfs_trans_handle *trans,
BUG_ON(ret); BUG_ON(ret);
if (btrfs_should_throttle_delayed_refs(trans, root)) if (btrfs_should_throttle_delayed_refs(trans, root))
btrfs_async_run_delayed_refs(root, btrfs_async_run_delayed_refs(root,
trans->transid, trans->delayed_ref_updates * 2,
trans->delayed_ref_updates * 2, 0); trans->transid, 0);
if (be_nice) { if (be_nice) {
if (truncate_space_check(trans, root, if (truncate_space_check(trans, root,
extent_num_bytes)) { extent_num_bytes)) {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment