Commit dd65f7e1 authored by Takashi Iwai's avatar Takashi Iwai

ALSA: hda - Show the fatal CORB/RIRB error more clearly

The last fallback of CORB/RIRB communication error recovery is to turn
on the single command mode, and this last resort usually means that
something is really screwed up.  Instead of a normal dev_err(), show
the error more clearly with dev_WARN() with the caller stack trace.

Also, show the bus-reset fallback also as an error, too.
Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
parent 5e291a90
...@@ -864,10 +864,13 @@ static int azx_rirb_get_response(struct hdac_bus *bus, unsigned int addr, ...@@ -864,10 +864,13 @@ static int azx_rirb_get_response(struct hdac_bus *bus, unsigned int addr,
*/ */
if (hbus->allow_bus_reset && !hbus->response_reset && !hbus->in_reset) { if (hbus->allow_bus_reset && !hbus->response_reset && !hbus->in_reset) {
hbus->response_reset = 1; hbus->response_reset = 1;
dev_err(chip->card->dev,
"No response from codec, resetting bus: last cmd=0x%08x\n",
bus->last_cmd[addr]);
return -EAGAIN; /* give a chance to retry */ return -EAGAIN; /* give a chance to retry */
} }
dev_err(chip->card->dev, dev_WARN(chip->card->dev,
"azx_get_response timeout, switching to single_cmd mode: last cmd=0x%08x\n", "azx_get_response timeout, switching to single_cmd mode: last cmd=0x%08x\n",
bus->last_cmd[addr]); bus->last_cmd[addr]);
chip->single_cmd = 1; chip->single_cmd = 1;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment