Commit dde5abee authored by Josef Bacik's avatar Josef Bacik Committed by Chris Mason

Btrfs: check cache->caching_ctl before returning if caching has started

With the free space disk caching we can mark the block group as started with the
caching, but we don't have a caching ctl.  This can race with anybody else who
tries to get the caching ctl before we cache (this is very hard to do btw).  So
instead check to see if cache->caching_ctl is set, and if not return NULL.
Thanks,
Signed-off-by: default avatarJosef Bacik <josef@redhat.com>
parent 9d66e233
...@@ -242,6 +242,12 @@ get_caching_control(struct btrfs_block_group_cache *cache) ...@@ -242,6 +242,12 @@ get_caching_control(struct btrfs_block_group_cache *cache)
return NULL; return NULL;
} }
/* We're loading it the fast way, so we don't have a caching_ctl. */
if (!cache->caching_ctl) {
spin_unlock(&cache->lock);
return NULL;
}
ctl = cache->caching_ctl; ctl = cache->caching_ctl;
atomic_inc(&ctl->count); atomic_inc(&ctl->count);
spin_unlock(&cache->lock); spin_unlock(&cache->lock);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment