Commit de02deab authored by Eric Dumazet's avatar Eric Dumazet Committed by Jakub Kicinski

sit: use exit_batch_rtnl() method

exit_batch_rtnl() is called while RTNL is held,
and devices to be unregistered can be queued in the dev_kill_list.

This saves one rtnl_lock()/rtnl_unlock() pair
and one unregister_netdevice_many() call.
Signed-off-by: default avatarEric Dumazet <edumazet@google.com>
Reviewed-by: default avatarAntoine Tenart <atenart@kernel.org>
Link: https://lore.kernel.org/r/20240206144313.2050392-14-edumazet@google.comSigned-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 7a99f3c1
...@@ -1875,22 +1875,19 @@ static int __net_init sit_init_net(struct net *net) ...@@ -1875,22 +1875,19 @@ static int __net_init sit_init_net(struct net *net)
return err; return err;
} }
static void __net_exit sit_exit_batch_net(struct list_head *net_list) static void __net_exit sit_exit_batch_rtnl(struct list_head *net_list,
struct list_head *dev_to_kill)
{ {
LIST_HEAD(list);
struct net *net; struct net *net;
rtnl_lock(); ASSERT_RTNL();
list_for_each_entry(net, net_list, exit_list) list_for_each_entry(net, net_list, exit_list)
sit_destroy_tunnels(net, &list); sit_destroy_tunnels(net, dev_to_kill);
unregister_netdevice_many(&list);
rtnl_unlock();
} }
static struct pernet_operations sit_net_ops = { static struct pernet_operations sit_net_ops = {
.init = sit_init_net, .init = sit_init_net,
.exit_batch = sit_exit_batch_net, .exit_batch_rtnl = sit_exit_batch_rtnl,
.id = &sit_net_id, .id = &sit_net_id,
.size = sizeof(struct sit_net), .size = sizeof(struct sit_net),
}; };
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment