Commit de2fc492 authored by Joe Perches's avatar Joe Perches Committed by Linus Torvalds

scripts/get_maintainer.pl: warn on missing git or git repository

support older versions of grep (use -E not -P)
no need to return data in routine recent_git_signoffs
Signed-off-by: default avatarJoe Perches <joe@perches.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent f5f5078d
...@@ -443,11 +443,21 @@ sub recent_git_signoffs { ...@@ -443,11 +443,21 @@ sub recent_git_signoffs {
my @lines = (); my @lines = ();
if (which("git") eq "") { if (which("git") eq "") {
die("$P: git not found. Add --nogit to options?\n"); warn("$P: git not found. Add --nogit to options?\n");
return;
}
if (!(-d ".git")) {
warn("$P: .git repository not found.\n");
warn("Use a .git repository for better results.\n");
warn("ie: git clone git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux-2.6.git\n");
return;
} }
$cmd = "git log --since=${email_git_since} -- ${file}"; $cmd = "git log --since=${email_git_since} -- ${file}";
$cmd .= " | grep -Pi \"^[-_ a-z]+by:.*\\\@.*\$\""; $cmd .= " | grep -Ei \"^[-_ a-z]+by:.*\\\@.*\$\"";
if (!$email_git_penguin_chiefs) {
$cmd .= " | grep -Ev \"${penguin_chiefs}\"";
}
$cmd .= " | cut -f2- -d\":\""; $cmd .= " | cut -f2- -d\":\"";
$cmd .= " | sort | uniq -c | sort -rn"; $cmd .= " | sort | uniq -c | sort -rn";
...@@ -486,7 +496,6 @@ sub recent_git_signoffs { ...@@ -486,7 +496,6 @@ sub recent_git_signoffs {
push(@email_to, $line); push(@email_to, $line);
} }
} }
return $output;
} }
sub uniq { sub uniq {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment