Commit df060ede authored by Alexander Usyskin's avatar Alexander Usyskin Committed by Greg Kroah-Hartman

mei: don't schedule suspend in pm idle

commit d5d83f8a upstream.

Calling pm_schedule_suspend from the runtime pm idle callback
may reschedule existing timer, thus in case of frequent runtime
rpm idle call the suspend maybe starved.
Instead we call pm_runtime_autosuspend which is checking if the
timer is already charged.

An example is monitoring device pci config space.
Pci config sysfs handlers calls pci_config_pm_runtime_put/get
helpers which in turns calls to device idle callback
Signed-off-by: default avatarAlexander Usyskin <alexander.usyskin@intel.com>
Signed-off-by: default avatarTomas Winkler <tomas.winkler@intel.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 06dcc692
...@@ -369,7 +369,7 @@ static int mei_me_pm_runtime_idle(struct device *device) ...@@ -369,7 +369,7 @@ static int mei_me_pm_runtime_idle(struct device *device)
if (!dev) if (!dev)
return -ENODEV; return -ENODEV;
if (mei_write_is_idle(dev)) if (mei_write_is_idle(dev))
pm_schedule_suspend(device, MEI_ME_RPM_TIMEOUT * 2); pm_runtime_autosuspend(device);
return -EBUSY; return -EBUSY;
} }
......
...@@ -306,7 +306,7 @@ static int mei_txe_pm_runtime_idle(struct device *device) ...@@ -306,7 +306,7 @@ static int mei_txe_pm_runtime_idle(struct device *device)
if (!dev) if (!dev)
return -ENODEV; return -ENODEV;
if (mei_write_is_idle(dev)) if (mei_write_is_idle(dev))
pm_schedule_suspend(device, MEI_TXI_RPM_TIMEOUT * 2); pm_runtime_autosuspend(device);
return -EBUSY; return -EBUSY;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment