Commit e007687c authored by Lee Duncan's avatar Lee Duncan Committed by Jiri Slaby

target: Allow Write Exclusive non-reservation holders to READ

commit 1ecc7586 upstream.

For PGR reservation of type Write Exclusive Access, allow all non
reservation holding I_T nexuses with active registrations to READ
from the device.

This addresses a bug where active registrations that attempted
to READ would result in an reservation conflict.
Signed-off-by: default avatarLee Duncan <lduncan@suse.com>
Signed-off-by: default avatarNicholas Bellinger <nab@linux-iscsi.org>
Signed-off-by: default avatarJiri Slaby <jslaby@suse.cz>
parent 84d0034c
...@@ -528,6 +528,18 @@ static int core_scsi3_pr_seq_non_holder( ...@@ -528,6 +528,18 @@ static int core_scsi3_pr_seq_non_holder(
return 0; return 0;
} }
} else if (we && registered_nexus) {
/*
* Reads are allowed for Write Exclusive locks
* from all registrants.
*/
if (cmd->data_direction == DMA_FROM_DEVICE) {
pr_debug("Allowing READ CDB: 0x%02x for %s"
" reservation\n", cdb[0],
core_scsi3_pr_dump_type(pr_reg_type));
return 0;
}
} }
pr_debug("%s Conflict for %sregistered nexus %s CDB: 0x%2x" pr_debug("%s Conflict for %sregistered nexus %s CDB: 0x%2x"
" for %s reservation\n", transport_dump_cmd_direction(cmd), " for %s reservation\n", transport_dump_cmd_direction(cmd),
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment