Commit e0150252 authored by Uwe Kleine-König's avatar Uwe Kleine-König Committed by Thierry Reding

pwm: mediatek: Simplify using devm_pwmchip_add()

This allows to drop the platform_driver's remove function. This is the
only user of driver data so this can go away, too.
Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: default avatarThierry Reding <thierry.reding@gmail.com>
parent da68a9f4
...@@ -253,13 +253,11 @@ static int pwm_mediatek_probe(struct platform_device *pdev) ...@@ -253,13 +253,11 @@ static int pwm_mediatek_probe(struct platform_device *pdev)
} }
} }
platform_set_drvdata(pdev, pc);
pc->chip.dev = &pdev->dev; pc->chip.dev = &pdev->dev;
pc->chip.ops = &pwm_mediatek_ops; pc->chip.ops = &pwm_mediatek_ops;
pc->chip.npwm = pc->soc->num_pwms; pc->chip.npwm = pc->soc->num_pwms;
ret = pwmchip_add(&pc->chip); ret = devm_pwmchip_add(&pdev->dev, &pc->chip);
if (ret < 0) { if (ret < 0) {
dev_err(&pdev->dev, "pwmchip_add() failed: %d\n", ret); dev_err(&pdev->dev, "pwmchip_add() failed: %d\n", ret);
return ret; return ret;
...@@ -268,13 +266,6 @@ static int pwm_mediatek_probe(struct platform_device *pdev) ...@@ -268,13 +266,6 @@ static int pwm_mediatek_probe(struct platform_device *pdev)
return 0; return 0;
} }
static int pwm_mediatek_remove(struct platform_device *pdev)
{
struct pwm_mediatek_chip *pc = platform_get_drvdata(pdev);
return pwmchip_remove(&pc->chip);
}
static const struct pwm_mediatek_of_data mt2712_pwm_data = { static const struct pwm_mediatek_of_data mt2712_pwm_data = {
.num_pwms = 8, .num_pwms = 8,
.pwm45_fixup = false, .pwm45_fixup = false,
...@@ -335,7 +326,6 @@ static struct platform_driver pwm_mediatek_driver = { ...@@ -335,7 +326,6 @@ static struct platform_driver pwm_mediatek_driver = {
.of_match_table = pwm_mediatek_of_match, .of_match_table = pwm_mediatek_of_match,
}, },
.probe = pwm_mediatek_probe, .probe = pwm_mediatek_probe,
.remove = pwm_mediatek_remove,
}; };
module_platform_driver(pwm_mediatek_driver); module_platform_driver(pwm_mediatek_driver);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment