Commit e01b5712 authored by Jiri Slaby (SUSE)'s avatar Jiri Slaby (SUSE) Committed by Greg Kroah-Hartman

tty: goldfish: use bool for is_write parameter

do_rw_io()'s is_write parameter is boolean, but typed int. Switch to the
former, so that it's obvious. (And the two users too.)
Signed-off-by: default avatar"Jiri Slaby (SUSE)" <jirislaby@kernel.org>
Link: https://lore.kernel.org/r/20231206073712.17776-2-jirislaby@kernel.orgSigned-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 173ebded
...@@ -53,7 +53,7 @@ static struct goldfish_tty *goldfish_ttys; ...@@ -53,7 +53,7 @@ static struct goldfish_tty *goldfish_ttys;
static void do_rw_io(struct goldfish_tty *qtty, static void do_rw_io(struct goldfish_tty *qtty,
unsigned long address, unsigned long address,
unsigned int count, unsigned int count,
int is_write) bool is_write)
{ {
unsigned long irq_flags; unsigned long irq_flags;
void __iomem *base = qtty->base; void __iomem *base = qtty->base;
...@@ -76,7 +76,7 @@ static void do_rw_io(struct goldfish_tty *qtty, ...@@ -76,7 +76,7 @@ static void do_rw_io(struct goldfish_tty *qtty,
static void goldfish_tty_rw(struct goldfish_tty *qtty, static void goldfish_tty_rw(struct goldfish_tty *qtty,
unsigned long addr, unsigned long addr,
unsigned int count, unsigned int count,
int is_write) bool is_write)
{ {
dma_addr_t dma_handle; dma_addr_t dma_handle;
enum dma_data_direction dma_dir; enum dma_data_direction dma_dir;
...@@ -129,7 +129,7 @@ static void goldfish_tty_do_write(int line, const u8 *buf, unsigned int count) ...@@ -129,7 +129,7 @@ static void goldfish_tty_do_write(int line, const u8 *buf, unsigned int count)
{ {
struct goldfish_tty *qtty = &goldfish_ttys[line]; struct goldfish_tty *qtty = &goldfish_ttys[line];
goldfish_tty_rw(qtty, (unsigned long)buf, count, 1); goldfish_tty_rw(qtty, (unsigned long)buf, count, true);
} }
static irqreturn_t goldfish_tty_interrupt(int irq, void *dev_id) static irqreturn_t goldfish_tty_interrupt(int irq, void *dev_id)
...@@ -145,7 +145,7 @@ static irqreturn_t goldfish_tty_interrupt(int irq, void *dev_id) ...@@ -145,7 +145,7 @@ static irqreturn_t goldfish_tty_interrupt(int irq, void *dev_id)
count = tty_prepare_flip_string(&qtty->port, &buf, count); count = tty_prepare_flip_string(&qtty->port, &buf, count);
goldfish_tty_rw(qtty, (unsigned long)buf, count, 0); goldfish_tty_rw(qtty, (unsigned long)buf, count, false);
tty_flip_buffer_push(&qtty->port); tty_flip_buffer_push(&qtty->port);
return IRQ_HANDLED; return IRQ_HANDLED;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment