Commit e05a5f51 authored by Eric Dumazet's avatar Eric Dumazet Committed by David S. Miller

net: annotate sk->sk_err write from do_recvmmsg()

do_recvmmsg() can write to sk->sk_err from multiple threads.

As said before, many other points reading or writing sk_err
need annotations.

Fixes: 34b88a68 ("net: Fix use after free in the recvmmsg exit path")
Signed-off-by: default avatarEric Dumazet <edumazet@google.com>
Reported-by: default avatarsyzbot <syzkaller@googlegroups.com>
Reviewed-by: default avatarKuniyuki Iwashima <kuniyu@amazon.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent a939d149
...@@ -2911,7 +2911,7 @@ static int do_recvmmsg(int fd, struct mmsghdr __user *mmsg, ...@@ -2911,7 +2911,7 @@ static int do_recvmmsg(int fd, struct mmsghdr __user *mmsg,
* error to return on the next call or if the * error to return on the next call or if the
* app asks about it using getsockopt(SO_ERROR). * app asks about it using getsockopt(SO_ERROR).
*/ */
sock->sk->sk_err = -err; WRITE_ONCE(sock->sk->sk_err, -err);
} }
out_put: out_put:
fput_light(sock->file, fput_needed); fput_light(sock->file, fput_needed);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment