Commit e06124bc authored by Dan Carpenter's avatar Dan Carpenter Committed by Luis Henriques

devres: fix a for loop bounds check

commit 1f35d04a upstream.

The iomap[] array has PCIM_IOMAP_MAX (6) elements and not
DEVICE_COUNT_RESOURCE (16).  This bug was found using a static checker.
It may be that the "if (!(mask & (1 << i)))" check means we never
actually go past the end of the array in real life.

Fixes: ec04b075 ('iomap: implement pcim_iounmap_regions()')
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Acked-by: default avatarTejun Heo <tj@kernel.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: default avatarLuis Henriques <luis.henriques@canonical.com>
parent 33b81c78
...@@ -425,7 +425,7 @@ void pcim_iounmap_regions(struct pci_dev *pdev, int mask) ...@@ -425,7 +425,7 @@ void pcim_iounmap_regions(struct pci_dev *pdev, int mask)
if (!iomap) if (!iomap)
return; return;
for (i = 0; i < DEVICE_COUNT_RESOURCE; i++) { for (i = 0; i < PCIM_IOMAP_MAX; i++) {
if (!(mask & (1 << i))) if (!(mask & (1 << i)))
continue; continue;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment