Commit e0a64d1d authored by Krzysztof Kozlowski's avatar Krzysztof Kozlowski Committed by Jakub Kicinski

nfc: s3fwrn5: let core configure the interrupt trigger

If interrupt trigger is not set when requesting the interrupt, the core
will take care of reading trigger type from Devicetree.  There is no
point to do it in the driver.
Signed-off-by: default avatarKrzysztof Kozlowski <krzk@kernel.org>
Link: https://lore.kernel.org/r/20201210211824.214949-1-krzk@kernel.orgSigned-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 771c8901
...@@ -179,8 +179,6 @@ static int s3fwrn5_i2c_probe(struct i2c_client *client, ...@@ -179,8 +179,6 @@ static int s3fwrn5_i2c_probe(struct i2c_client *client,
const struct i2c_device_id *id) const struct i2c_device_id *id)
{ {
struct s3fwrn5_i2c_phy *phy; struct s3fwrn5_i2c_phy *phy;
struct irq_data *irq_data;
unsigned long irqflags;
int ret; int ret;
phy = devm_kzalloc(&client->dev, sizeof(*phy), GFP_KERNEL); phy = devm_kzalloc(&client->dev, sizeof(*phy), GFP_KERNEL);
...@@ -214,11 +212,8 @@ static int s3fwrn5_i2c_probe(struct i2c_client *client, ...@@ -214,11 +212,8 @@ static int s3fwrn5_i2c_probe(struct i2c_client *client,
if (ret < 0) if (ret < 0)
return ret; return ret;
irq_data = irq_get_irq_data(client->irq);
irqflags = irqd_get_trigger_type(irq_data) | IRQF_ONESHOT;
ret = devm_request_threaded_irq(&client->dev, phy->i2c_dev->irq, NULL, ret = devm_request_threaded_irq(&client->dev, phy->i2c_dev->irq, NULL,
s3fwrn5_i2c_irq_thread_fn, irqflags, s3fwrn5_i2c_irq_thread_fn, IRQF_ONESHOT,
S3FWRN5_I2C_DRIVER_NAME, phy); S3FWRN5_I2C_DRIVER_NAME, phy);
if (ret) if (ret)
s3fwrn5_remove(phy->common.ndev); s3fwrn5_remove(phy->common.ndev);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment