Commit e0deb6a0 authored by Pavel Begunkov's avatar Pavel Begunkov Committed by Jens Axboe

io_uring: avoid io-wq -EAGAIN looping for !IOPOLL

If an opcode handler semi-reliably returns -EAGAIN, io_wq_submit_work()
might continue busily hammer the same handler over and over again, which
is not ideal. The -EAGAIN handling in question was put there only for
IOPOLL, so restrict it to IOPOLL mode only where there is no other
recourse than to retry as we cannot wait.

Fixes: def596e9 ("io_uring: support for IO polling")
Signed-off-by: default avatarPavel Begunkov <asml.silence@gmail.com>
Link: https://lore.kernel.org/r/f168b4f24181942f3614dd8ff648221736f572e6.1652433740.git.asml.silence@gmail.comSigned-off-by: default avatarJens Axboe <axboe@kernel.dk>
parent a8da73a3
...@@ -7573,6 +7573,8 @@ static void io_wq_submit_work(struct io_wq_work *work) ...@@ -7573,6 +7573,8 @@ static void io_wq_submit_work(struct io_wq_work *work)
* wait for request slots on the block side. * wait for request slots on the block side.
*/ */
if (!needs_poll) { if (!needs_poll) {
if (!(req->ctx->flags & IORING_SETUP_IOPOLL))
break;
cond_resched(); cond_resched();
continue; continue;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment