Commit e14a5993 authored by Eric Dumazet's avatar Eric Dumazet Committed by David S. Miller

net: dev_close() should check IFF_UP

Commit 44345724 (factorize sync-rcu call in
unregister_netdevice_many) mistakenly removed one test from dev_close()

Following actions trigger a BUG :

modprobe bonding
modprobe dummy
ifconfig bond0 up
ifenslave bond0 dummy0
rmmod dummy

dev_close() must not close a non IFF_UP device.

With help from Frank Blaschka and Einar EL Lueck
Reported-by: default avatarFrank Blaschka <blaschka@linux.vnet.ibm.com>
Reported-by: default avatarEinar EL Lueck <ELELUECK@de.ibm.com>
Signed-off-by: default avatarEric Dumazet <eric.dumazet@gmail.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 55aee10d
...@@ -1284,11 +1284,13 @@ static int dev_close_many(struct list_head *head) ...@@ -1284,11 +1284,13 @@ static int dev_close_many(struct list_head *head)
*/ */
int dev_close(struct net_device *dev) int dev_close(struct net_device *dev)
{ {
LIST_HEAD(single); if (dev->flags & IFF_UP) {
LIST_HEAD(single);
list_add(&dev->unreg_list, &single); list_add(&dev->unreg_list, &single);
dev_close_many(&single); dev_close_many(&single);
list_del(&single); list_del(&single);
}
return 0; return 0;
} }
EXPORT_SYMBOL(dev_close); EXPORT_SYMBOL(dev_close);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment