Commit e16ccfee authored by Mohammed Shafi Shajakhan's avatar Mohammed Shafi Shajakhan Committed by Kalle Valo

ath6kl: remove unnecessary check for NULL skb

dev_kfree_skb kernel API itself takes for checking for NULL
skb, so an explicit check is not required.
Signed-off-by: default avatarMohammed Shafi Shajakhan <mohammed@qca.qualcomm.com>
Signed-off-by: default avatarKalle Valo <kvalo@qca.qualcomm.com>
parent 895dc386
...@@ -509,9 +509,7 @@ static void destroy_htc_txctrl_packet(struct htc_packet *packet) ...@@ -509,9 +509,7 @@ static void destroy_htc_txctrl_packet(struct htc_packet *packet)
{ {
struct sk_buff *skb; struct sk_buff *skb;
skb = packet->skb; skb = packet->skb;
if (skb != NULL) dev_kfree_skb(skb);
dev_kfree_skb(skb);
kfree(packet); kfree(packet);
} }
...@@ -1054,6 +1052,7 @@ static int ath6kl_htc_pipe_rx_complete(struct ath6kl *ar, struct sk_buff *skb, ...@@ -1054,6 +1052,7 @@ static int ath6kl_htc_pipe_rx_complete(struct ath6kl *ar, struct sk_buff *skb,
dev_kfree_skb(skb); dev_kfree_skb(skb);
skb = NULL; skb = NULL;
goto free_skb; goto free_skb;
} }
...@@ -1089,8 +1088,7 @@ static int ath6kl_htc_pipe_rx_complete(struct ath6kl *ar, struct sk_buff *skb, ...@@ -1089,8 +1088,7 @@ static int ath6kl_htc_pipe_rx_complete(struct ath6kl *ar, struct sk_buff *skb,
skb = NULL; skb = NULL;
free_skb: free_skb:
if (skb != NULL) dev_kfree_skb(skb);
dev_kfree_skb(skb);
return status; return status;
......
...@@ -159,10 +159,8 @@ static void ath6kl_usb_free_urb_to_pipe(struct ath6kl_usb_pipe *pipe, ...@@ -159,10 +159,8 @@ static void ath6kl_usb_free_urb_to_pipe(struct ath6kl_usb_pipe *pipe,
static void ath6kl_usb_cleanup_recv_urb(struct ath6kl_urb_context *urb_context) static void ath6kl_usb_cleanup_recv_urb(struct ath6kl_urb_context *urb_context)
{ {
if (urb_context->skb != NULL) { dev_kfree_skb(urb_context->skb);
dev_kfree_skb(urb_context->skb); urb_context->skb = NULL;
urb_context->skb = NULL;
}
ath6kl_usb_free_urb_to_pipe(urb_context->pipe, urb_context); ath6kl_usb_free_urb_to_pipe(urb_context->pipe, urb_context);
} }
......
...@@ -2481,16 +2481,11 @@ static int ath6kl_wmi_sync_point(struct wmi *wmi, u8 if_idx) ...@@ -2481,16 +2481,11 @@ static int ath6kl_wmi_sync_point(struct wmi *wmi, u8 if_idx)
free_cmd_skb: free_cmd_skb:
/* free up any resources left over (possibly due to an error) */ /* free up any resources left over (possibly due to an error) */
if (skb) dev_kfree_skb(skb);
dev_kfree_skb(skb);
free_data_skb: free_data_skb:
for (index = 0; index < num_pri_streams; index++) { for (index = 0; index < num_pri_streams; index++)
if (data_sync_bufs[index].skb != NULL) { dev_kfree_skb((struct sk_buff *)data_sync_bufs[index].skb);
dev_kfree_skb((struct sk_buff *)data_sync_bufs[index].
skb);
}
}
return ret; return ret;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment