Commit e1c36595 authored by Jan Kara's avatar Jan Kara Committed by Theodore Ts'o

ext4: fix WARN_ON from ext4_releasepage()

ext4_releasepage() warns when it is passed a page with PageChecked set.
However this can correctly happen when invalidate_inode_pages2_range()
invalidates pages - and we should fail the release in that case. Since
the page was dirty anyway, it won't be discarded and no harm has
happened but it's good to be safe. Also remove bogus page_has_buffers()
check - we are guaranteed page has buffers in this function.
Reported-by: default avatarZheng Liu <gnehzuil.liu@gmail.com>
Tested-by: default avatarZheng Liu <wenqing.lz@taobao.com>
Signed-off-by: default avatar"Theodore Ts'o" <tytso@mit.edu>
Signed-off-by: default avatarJan Kara <jack@suse.cz>
parent 3a225670
...@@ -3018,8 +3018,8 @@ static int ext4_releasepage(struct page *page, gfp_t wait) ...@@ -3018,8 +3018,8 @@ static int ext4_releasepage(struct page *page, gfp_t wait)
trace_ext4_releasepage(page); trace_ext4_releasepage(page);
WARN_ON(PageChecked(page)); /* Page has dirty journalled data -> cannot release */
if (!page_has_buffers(page)) if (PageChecked(page))
return 0; return 0;
if (journal) if (journal)
return jbd2_journal_try_to_free_buffers(journal, page, wait); return jbd2_journal_try_to_free_buffers(journal, page, wait);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment