Commit e1d15969 authored by Colin Ian King's avatar Colin Ian King Committed by Guenter Roeck

hwmon: (ltc2992) Fix less than zero comparisons with an unsigned integer

There are several occurrances of a less than zero error check on
a u32 unsigned integer. These will never be true. Fix this by making
reg_value a plain int.

Addresses-Coverity: ("Unsigned comparison against zero")
Fixes: e126370240e0 ("hwmon: (ltc2992) Add support")
Signed-off-by: default avatarColin Ian King <colin.king@canonical.com>
Link: https://lore.kernel.org/r/20201207142410.168987-1-colin.king@canonical.comSigned-off-by: default avatarGuenter Roeck <linux@roeck-us.net>
parent 966ead91
...@@ -480,7 +480,7 @@ static int ltc2992_read_gpios_in(struct device *dev, u32 attr, int nr_gpio, long ...@@ -480,7 +480,7 @@ static int ltc2992_read_gpios_in(struct device *dev, u32 attr, int nr_gpio, long
static int ltc2992_read_in_alarm(struct ltc2992_state *st, int channel, long *val, u32 attr) static int ltc2992_read_in_alarm(struct ltc2992_state *st, int channel, long *val, u32 attr)
{ {
u32 reg_val; int reg_val;
u32 mask; u32 mask;
if (attr == hwmon_in_max_alarm) if (attr == hwmon_in_max_alarm)
...@@ -534,7 +534,7 @@ static int ltc2992_read_in(struct device *dev, u32 attr, int channel, long *val) ...@@ -534,7 +534,7 @@ static int ltc2992_read_in(struct device *dev, u32 attr, int channel, long *val)
static int ltc2992_get_current(struct ltc2992_state *st, u32 reg, u32 channel, long *val) static int ltc2992_get_current(struct ltc2992_state *st, u32 reg, u32 channel, long *val)
{ {
u32 reg_val; int reg_val;
reg_val = ltc2992_read_reg(st, reg, 2); reg_val = ltc2992_read_reg(st, reg, 2);
if (reg_val < 0) if (reg_val < 0)
...@@ -558,7 +558,7 @@ static int ltc2992_set_current(struct ltc2992_state *st, u32 reg, u32 channel, l ...@@ -558,7 +558,7 @@ static int ltc2992_set_current(struct ltc2992_state *st, u32 reg, u32 channel, l
static int ltc2992_read_curr_alarm(struct ltc2992_state *st, int channel, long *val, u32 attr) static int ltc2992_read_curr_alarm(struct ltc2992_state *st, int channel, long *val, u32 attr)
{ {
u32 reg_val; int reg_val;
u32 mask; u32 mask;
if (attr == hwmon_curr_max_alarm) if (attr == hwmon_curr_max_alarm)
...@@ -609,7 +609,7 @@ static int ltc2992_read_curr(struct device *dev, u32 attr, int channel, long *va ...@@ -609,7 +609,7 @@ static int ltc2992_read_curr(struct device *dev, u32 attr, int channel, long *va
static int ltc2992_get_power(struct ltc2992_state *st, u32 reg, u32 channel, long *val) static int ltc2992_get_power(struct ltc2992_state *st, u32 reg, u32 channel, long *val)
{ {
u32 reg_val; int reg_val;
reg_val = ltc2992_read_reg(st, reg, 3); reg_val = ltc2992_read_reg(st, reg, 3);
if (reg_val < 0) if (reg_val < 0)
...@@ -633,7 +633,7 @@ static int ltc2992_set_power(struct ltc2992_state *st, u32 reg, u32 channel, lon ...@@ -633,7 +633,7 @@ static int ltc2992_set_power(struct ltc2992_state *st, u32 reg, u32 channel, lon
static int ltc2992_read_power_alarm(struct ltc2992_state *st, int channel, long *val, u32 attr) static int ltc2992_read_power_alarm(struct ltc2992_state *st, int channel, long *val, u32 attr)
{ {
u32 reg_val; int reg_val;
u32 mask; u32 mask;
if (attr == hwmon_power_max_alarm) if (attr == hwmon_power_max_alarm)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment