Commit e1f1a0e6 authored by Greg Kroah-Hartman's avatar Greg Kroah-Hartman

Staging: hv: mouse_vsc: fix comment coding style

Also mark this as a nice FIXME as we shouldn't ever
care about the value of an atomic variable, which makes me seriously
doubt the validity of this reference counting code.  Odds are it can be
ripped out completly, or at the very least, converted to using a kref.

Cc: Hank Janssen <hjanssen@microsoft.com>
Cc: K. Y. Srinivasan <kys@microsoft.com>
Cc: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
parent 6a5bfc17
...@@ -157,8 +157,14 @@ static inline struct mousevsc_dev *GetInputDevice(struct hv_device *Device) ...@@ -157,8 +157,14 @@ static inline struct mousevsc_dev *GetInputDevice(struct hv_device *Device)
inputDevice = (struct mousevsc_dev *)Device->ext; inputDevice = (struct mousevsc_dev *)Device->ext;
// printk(KERN_ERR "-------------------------> REFCOUNT = %d", /*
// inputDevice->RefCount); * FIXME
* This sure isn't a valid thing to print for debugging, no matter
* what the intention is...
*
* printk(KERN_ERR "-------------------------> REFCOUNT = %d",
* inputDevice->RefCount);
*/
if (inputDevice && atomic_read(&inputDevice->RefCount) > 1) if (inputDevice && atomic_read(&inputDevice->RefCount) > 1)
atomic_inc(&inputDevice->RefCount); atomic_inc(&inputDevice->RefCount);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment