Commit e282fb7f authored by Andreas Gruenbacher's avatar Andreas Gruenbacher Committed by Al Viro

hfsplus: Remove unused xattr handler list operations

The list operations can never be called; they are even documented to be
unused.
Signed-off-by: default avatarAndreas Gruenbacher <agruenba@redhat.com>
Reviewed-by: default avatarChristoph Hellwig <hch@lst.de>
Signed-off-by: default avatarAl Viro <viro@zeniv.linux.org.uk>
parent 13d3408f
...@@ -893,19 +893,8 @@ static int hfsplus_osx_setxattr(struct dentry *dentry, const char *name, ...@@ -893,19 +893,8 @@ static int hfsplus_osx_setxattr(struct dentry *dentry, const char *name,
return __hfsplus_setxattr(d_inode(dentry), name, buffer, size, flags); return __hfsplus_setxattr(d_inode(dentry), name, buffer, size, flags);
} }
static size_t hfsplus_osx_listxattr(struct dentry *dentry, char *list,
size_t list_size, const char *name, size_t name_len, int type)
{
/*
* This method is not used.
* It is used hfsplus_listxattr() instead of generic_listxattr().
*/
return -EOPNOTSUPP;
}
const struct xattr_handler hfsplus_xattr_osx_handler = { const struct xattr_handler hfsplus_xattr_osx_handler = {
.prefix = XATTR_MAC_OSX_PREFIX, .prefix = XATTR_MAC_OSX_PREFIX,
.list = hfsplus_osx_listxattr,
.get = hfsplus_osx_getxattr, .get = hfsplus_osx_getxattr,
.set = hfsplus_osx_setxattr, .set = hfsplus_osx_setxattr,
}; };
...@@ -29,16 +29,6 @@ static int hfsplus_security_setxattr(struct dentry *dentry, const char *name, ...@@ -29,16 +29,6 @@ static int hfsplus_security_setxattr(struct dentry *dentry, const char *name,
XATTR_SECURITY_PREFIX_LEN); XATTR_SECURITY_PREFIX_LEN);
} }
static size_t hfsplus_security_listxattr(struct dentry *dentry, char *list,
size_t list_size, const char *name, size_t name_len, int type)
{
/*
* This method is not used.
* It is used hfsplus_listxattr() instead of generic_listxattr().
*/
return -EOPNOTSUPP;
}
static int hfsplus_initxattrs(struct inode *inode, static int hfsplus_initxattrs(struct inode *inode,
const struct xattr *xattr_array, const struct xattr *xattr_array,
void *fs_info) void *fs_info)
...@@ -92,7 +82,6 @@ int hfsplus_init_inode_security(struct inode *inode, ...@@ -92,7 +82,6 @@ int hfsplus_init_inode_security(struct inode *inode,
const struct xattr_handler hfsplus_xattr_security_handler = { const struct xattr_handler hfsplus_xattr_security_handler = {
.prefix = XATTR_SECURITY_PREFIX, .prefix = XATTR_SECURITY_PREFIX,
.list = hfsplus_security_listxattr,
.get = hfsplus_security_getxattr, .get = hfsplus_security_getxattr,
.set = hfsplus_security_setxattr, .set = hfsplus_security_setxattr,
}; };
...@@ -26,19 +26,8 @@ static int hfsplus_trusted_setxattr(struct dentry *dentry, const char *name, ...@@ -26,19 +26,8 @@ static int hfsplus_trusted_setxattr(struct dentry *dentry, const char *name,
XATTR_TRUSTED_PREFIX, XATTR_TRUSTED_PREFIX_LEN); XATTR_TRUSTED_PREFIX, XATTR_TRUSTED_PREFIX_LEN);
} }
static size_t hfsplus_trusted_listxattr(struct dentry *dentry, char *list,
size_t list_size, const char *name, size_t name_len, int type)
{
/*
* This method is not used.
* It is used hfsplus_listxattr() instead of generic_listxattr().
*/
return -EOPNOTSUPP;
}
const struct xattr_handler hfsplus_xattr_trusted_handler = { const struct xattr_handler hfsplus_xattr_trusted_handler = {
.prefix = XATTR_TRUSTED_PREFIX, .prefix = XATTR_TRUSTED_PREFIX,
.list = hfsplus_trusted_listxattr,
.get = hfsplus_trusted_getxattr, .get = hfsplus_trusted_getxattr,
.set = hfsplus_trusted_setxattr, .set = hfsplus_trusted_setxattr,
}; };
...@@ -26,19 +26,8 @@ static int hfsplus_user_setxattr(struct dentry *dentry, const char *name, ...@@ -26,19 +26,8 @@ static int hfsplus_user_setxattr(struct dentry *dentry, const char *name,
XATTR_USER_PREFIX, XATTR_USER_PREFIX_LEN); XATTR_USER_PREFIX, XATTR_USER_PREFIX_LEN);
} }
static size_t hfsplus_user_listxattr(struct dentry *dentry, char *list,
size_t list_size, const char *name, size_t name_len, int type)
{
/*
* This method is not used.
* It is used hfsplus_listxattr() instead of generic_listxattr().
*/
return -EOPNOTSUPP;
}
const struct xattr_handler hfsplus_xattr_user_handler = { const struct xattr_handler hfsplus_xattr_user_handler = {
.prefix = XATTR_USER_PREFIX, .prefix = XATTR_USER_PREFIX,
.list = hfsplus_user_listxattr,
.get = hfsplus_user_getxattr, .get = hfsplus_user_getxattr,
.set = hfsplus_user_setxattr, .set = hfsplus_user_setxattr,
}; };
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment