Commit e2d42311 authored by Peng Fan's avatar Peng Fan Committed by Will Deacon

iommu/arm-smmu: Drop devm_free_irq when driver detach

There is no need to call devm_free_irq when driver detach.
devres_release_all which is called after 'drv->remove' will
release all managed resources.
Signed-off-by: default avatarPeng Fan <van.freenix@gmail.com>
Reviewed-by: default avatarRobin Murphy <robin.murphy@arm.com>
Cc: Will Deacon <will.deacon@arm.com>
Signed-off-by: default avatarWill Deacon <will.deacon@arm.com>
parent 3eab887a
...@@ -1998,7 +1998,6 @@ static int arm_smmu_device_dt_probe(struct platform_device *pdev) ...@@ -1998,7 +1998,6 @@ static int arm_smmu_device_dt_probe(struct platform_device *pdev)
static int arm_smmu_device_remove(struct platform_device *pdev) static int arm_smmu_device_remove(struct platform_device *pdev)
{ {
int i;
struct device *dev = &pdev->dev; struct device *dev = &pdev->dev;
struct arm_smmu_device *curr, *smmu = NULL; struct arm_smmu_device *curr, *smmu = NULL;
struct rb_node *node; struct rb_node *node;
...@@ -2025,9 +2024,6 @@ static int arm_smmu_device_remove(struct platform_device *pdev) ...@@ -2025,9 +2024,6 @@ static int arm_smmu_device_remove(struct platform_device *pdev)
if (!bitmap_empty(smmu->context_map, ARM_SMMU_MAX_CBS)) if (!bitmap_empty(smmu->context_map, ARM_SMMU_MAX_CBS))
dev_err(dev, "removing device with active domains!\n"); dev_err(dev, "removing device with active domains!\n");
for (i = 0; i < smmu->num_global_irqs; ++i)
devm_free_irq(smmu->dev, smmu->irqs[i], smmu);
/* Turn the thing off */ /* Turn the thing off */
writel(sCR0_CLIENTPD, ARM_SMMU_GR0_NS(smmu) + ARM_SMMU_GR0_sCR0); writel(sCR0_CLIENTPD, ARM_SMMU_GR0_NS(smmu) + ARM_SMMU_GR0_sCR0);
return 0; return 0;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment