Commit e3df4c6e authored by Michal Hocko's avatar Michal Hocko Committed by Linus Torvalds

mm, memory_hotplug: __offline_pages fix wrong locking

Jan has noticed that we do double unlock on some failure paths when
offlining a page range.  This is indeed the case when
test_pages_in_a_zone respp.  start_isolate_page_range fail.  This was an
omission when forward porting the debugging patch from an older kernel.

Fix the issue by dropping mem_hotplug_done from the failure condition
and keeping the single unlock in the catch all failure path.

Link: http://lkml.kernel.org/r/20190115120307.22768-1-mhocko@kernel.org
Fixes: 79605093 ("mm, memory_hotplug: print reason for the offlining failure")
Signed-off-by: default avatarMichal Hocko <mhocko@suse.com>
Reported-by: default avatarJan Kara <jack@suse.cz>
Reviewed-by: default avatarJan Kara <jack@suse.cz>
Tested-by: default avatarJan Kara <jack@suse.cz>
Reviewed-by: default avatarOscar Salvador <osalvador@suse.de>
Reviewed-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 6376360e
...@@ -1570,7 +1570,6 @@ static int __ref __offline_pages(unsigned long start_pfn, ...@@ -1570,7 +1570,6 @@ static int __ref __offline_pages(unsigned long start_pfn,
we assume this for now. .*/ we assume this for now. .*/
if (!test_pages_in_a_zone(start_pfn, end_pfn, &valid_start, if (!test_pages_in_a_zone(start_pfn, end_pfn, &valid_start,
&valid_end)) { &valid_end)) {
mem_hotplug_done();
ret = -EINVAL; ret = -EINVAL;
reason = "multizone range"; reason = "multizone range";
goto failed_removal; goto failed_removal;
...@@ -1585,7 +1584,6 @@ static int __ref __offline_pages(unsigned long start_pfn, ...@@ -1585,7 +1584,6 @@ static int __ref __offline_pages(unsigned long start_pfn,
MIGRATE_MOVABLE, MIGRATE_MOVABLE,
SKIP_HWPOISON | REPORT_FAILURE); SKIP_HWPOISON | REPORT_FAILURE);
if (ret) { if (ret) {
mem_hotplug_done();
reason = "failure to isolate range"; reason = "failure to isolate range";
goto failed_removal; goto failed_removal;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment