Commit e52d30f2 authored by Roland Vossen's avatar Roland Vossen Committed by Greg Kroah-Hartman

staging: brcm80211: Changed comments

Code cleanup. BCM4321 is not supported by this driver. Removed 'XXX' in
comments since they do not signal a critical issue to be patched. Removed
FIXME in comment since it signalled a problem in the Minstrel algorithm,
not in our driver.
Signed-off-by: default avatarRoland Vossen <rvossen@broadcom.com>
Reviewed-by: default avatarArend van Spriel <arend@broadcom.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
parent 94daaf70
...@@ -3567,7 +3567,6 @@ u16 brcms_b_rate_shm_offset(struct brcms_c_hw_info *wlc_hw, u8 rate) ...@@ -3567,7 +3567,6 @@ u16 brcms_b_rate_shm_offset(struct brcms_c_hw_info *wlc_hw, u8 rate)
u8 phy_rate, index; u8 phy_rate, index;
/* get the phy specific rate encoding for the PLCP SIGNAL field */ /* get the phy specific rate encoding for the PLCP SIGNAL field */
/* XXX4321 fixup needed ? */
if (IS_OFDM(rate)) if (IS_OFDM(rate))
table_ptr = M_RT_DIRMAP_A; table_ptr = M_RT_DIRMAP_A;
else else
......
...@@ -644,7 +644,7 @@ brcms_ops_ampdu_action(struct ieee80211_hw *hw, ...@@ -644,7 +644,7 @@ brcms_ops_ampdu_action(struct ieee80211_hw *hw,
tid); tid);
return -EINVAL; return -EINVAL;
} }
/* XXX: Use the starting sequence number provided ... */ /* Future improvement: Use the starting sequence number provided ... */
*ssn = 0; *ssn = 0;
ieee80211_start_tx_ba_cb_irqsafe(vif, sta->addr, tid); ieee80211_start_tx_ba_cb_irqsafe(vif, sta->addr, tid);
break; break;
...@@ -1089,11 +1089,6 @@ static int ieee_hw_init(struct ieee80211_hw *hw) ...@@ -1089,11 +1089,6 @@ static int ieee_hw_init(struct ieee80211_hw *hw)
hw->extra_tx_headroom = brcms_c_get_header_len(); hw->extra_tx_headroom = brcms_c_get_header_len();
hw->queues = N_TX_QUEUES; hw->queues = N_TX_QUEUES;
/* FIXME: this doesn't seem to be used properly in minstrel_ht.
* mac80211/status.c:ieee80211_tx_status() checks this value,
* but mac80211/rc80211_minstrel_ht.c:minstrel_ht_get_rate()
* appears to always set 3 rates
*/
hw->max_rates = 2; /* Primary rate and 1 fallback rate */ hw->max_rates = 2; /* Primary rate and 1 fallback rate */
hw->channel_change_time = 7 * 1000; /* channel change time is dependent on chip and band */ hw->channel_change_time = 7 * 1000; /* channel change time is dependent on chip and band */
......
...@@ -3165,7 +3165,7 @@ void brcms_c_txq_enq(void *ctx, struct scb *scb, struct sk_buff *sdu, ...@@ -3165,7 +3165,7 @@ void brcms_c_txq_enq(void *ctx, struct scb *scb, struct sk_buff *sdu,
"\n", wlc->pub->unit); "\n", wlc->pub->unit);
/* /*
* XXX we might hit this condtion in case * we might hit this condtion in case
* packet flooding from mac80211 stack * packet flooding from mac80211 stack
*/ */
brcmu_pkt_buf_free_skb(sdu); brcmu_pkt_buf_free_skb(sdu);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment