Commit e6391a18 authored by Ian Abbott's avatar Ian Abbott Committed by Greg Kroah-Hartman

staging: comedi: das08: Correct AI encoding for das08jr-16-ao

The element of `das08_boards[]` for the 'das08jr-16-ao' board has the
`ai_encoding` member set to `das08_encode12`.  It should be set to
`das08_encode16` same as the 'das08jr/16' board.  After all, this board
has 16-bit AI resolution.

The description of the A/D LSB register at offset 0 seems incorrect in
the user manual "cio-das08jr-16-ao.pdf" as it implies that the AI
resolution is only 12 bits.  The diagrams of the A/D LSB and MSB
registers show 15 data bits and a sign bit, which matches what the
software expects for the `das08_encode16` AI encoding method.

Cc: stable <stable@vger.kernel.org>
Signed-off-by: default avatarIan Abbott <abbotti@mev.co.uk>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 4a7a4f95
...@@ -623,7 +623,7 @@ static const struct das08_board_struct das08_boards[] = { ...@@ -623,7 +623,7 @@ static const struct das08_board_struct das08_boards[] = {
.ai = das08_ai_rinsn, .ai = das08_ai_rinsn,
.ai_nbits = 16, .ai_nbits = 16,
.ai_pg = das08_pg_none, .ai_pg = das08_pg_none,
.ai_encoding = das08_encode12, .ai_encoding = das08_encode16,
.ao = das08jr_ao_winsn, .ao = das08jr_ao_winsn,
.ao_nbits = 16, .ao_nbits = 16,
.di = das08jr_di_rbits, .di = das08jr_di_rbits,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment