Commit e784fcd7 authored by Takashi Iwai's avatar Takashi Iwai Committed by Kamal Mostafa

ALSA: usb-audio: Fix mixer ctl regression of Native Instrument devices

commit c4a359a0 upstream.

The commit [da6d2769: ALSA: usb-audio: Add resume support for
Native Instruments controls] brought a regression where the Native
Instrument audio devices don't get the correct value at update due to
the missing shift at writing.  This patch addresses it.

Fixes: da6d2769 ('ALSA: usb-audio: Add resume support for Native Instruments controls')
Reported-and-tested-by: default avatarOwen Williams <owilliams@mixxx.org>
Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
Signed-off-by: default avatarKamal Mostafa <kamal@canonical.com>
parent 0762a13f
...@@ -803,7 +803,7 @@ static int snd_nativeinstruments_control_put(struct snd_kcontrol *kcontrol, ...@@ -803,7 +803,7 @@ static int snd_nativeinstruments_control_put(struct snd_kcontrol *kcontrol,
return 0; return 0;
kcontrol->private_value &= ~(0xff << 24); kcontrol->private_value &= ~(0xff << 24);
kcontrol->private_value |= newval; kcontrol->private_value |= (unsigned int)newval << 24;
err = snd_ni_update_cur_val(list); err = snd_ni_update_cur_val(list);
return err < 0 ? err : 1; return err < 0 ? err : 1;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment