Commit e79aee49 authored by Rafael J. Wysocki's avatar Rafael J. Wysocki

PM: Avoid false-positive warnings in dev_pm_domain_set()

There is a WARN_ON() in dev_pm_domain_set() that triggers on attempts
to set the pm_domain pointer for devices with a driver bound.

However, that WARN_ON() triggers on attempts to clear the pointer
too and the test it uses is based on checking the device's
p->knode_driver pointer which still is set when the device bus
type's/driver's ->remove callback has been executed.  This
leads to false-positive warnings when bus type code calls
dev_pm_domain_set() to clear the pm_domain pointer after
invoking the driver's ->remove() callback.

To avoid those false-positives, make dev_pm_domain_set() check
if the pointer passed to it is NULL and skip the warning in
that case.

Fixes: 989561de (PM / Domains: add setter for dev.pm_domain)
Signed-off-by: default avatarRafael J. Wysocki <rafael.j.wysocki@intel.com>
Tested-by: default avatarAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Tested-by: default avatarSinan Kaya <okaya@codeaurora.org>
Tested-by: default avatarSteven Rostedt <rostedt@goodmis.org>
Acked-by: default avatarUlf Hansson <ulf.hansson@linaro.org>
parent 5be6ada3
...@@ -146,7 +146,7 @@ void dev_pm_domain_set(struct device *dev, struct dev_pm_domain *pd) ...@@ -146,7 +146,7 @@ void dev_pm_domain_set(struct device *dev, struct dev_pm_domain *pd)
if (dev->pm_domain == pd) if (dev->pm_domain == pd)
return; return;
WARN(device_is_bound(dev), WARN(pd && device_is_bound(dev),
"PM domains can only be changed for unbound devices\n"); "PM domains can only be changed for unbound devices\n");
dev->pm_domain = pd; dev->pm_domain = pd;
device_pm_check_callbacks(dev); device_pm_check_callbacks(dev);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment