Commit e7f0c424 authored by zhangyi (F)'s avatar zhangyi (F) Committed by Steven Rostedt (VMware)

tracing: Do not free iter->trace in fail path of tracing_open_pipe()

Commit d716ff71 ("tracing: Remove taking of trace_types_lock in
pipe files") use the current tracer instead of the copy in
tracing_open_pipe(), but it forget to remove the freeing sentence in
the error path.

There's an error path that can call kfree(iter->trace) after the iter->trace
was assigned to tr->current_trace, which would be bad to free.

Link: http://lkml.kernel.org/r/1550060946-45984-1-git-send-email-yi.zhang@huawei.com

Cc: stable@vger.kernel.org
Fixes: d716ff71 ("tracing: Remove taking of trace_types_lock in pipe files")
Signed-off-by: default avatarzhangyi (F) <yi.zhang@huawei.com>
Signed-off-by: default avatarSteven Rostedt (VMware) <rostedt@goodmis.org>
parent ce59b8e9
...@@ -5624,7 +5624,6 @@ static int tracing_open_pipe(struct inode *inode, struct file *filp) ...@@ -5624,7 +5624,6 @@ static int tracing_open_pipe(struct inode *inode, struct file *filp)
return ret; return ret;
fail: fail:
kfree(iter->trace);
kfree(iter); kfree(iter);
__trace_array_put(tr); __trace_array_put(tr);
mutex_unlock(&trace_types_lock); mutex_unlock(&trace_types_lock);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment