Commit e8cbe67a authored by Vojtech Pavlik's avatar Vojtech Pavlik

Make i8042.c even less picky about detecting an AUX port because of

broken chipsets that don't support the LOOP command or report failure
on the TEST command. Hopefully this won't screw any old 386/486
systems without the AUX port.
parent 7a017c2b
...@@ -654,24 +654,26 @@ static int __init i8042_check_aux(struct i8042_values *values) ...@@ -654,24 +654,26 @@ static int __init i8042_check_aux(struct i8042_values *values)
i8042_flush(); i8042_flush();
/* /*
* Internal loopback test - filters out AT-type i8042's * Internal loopback test - filters out AT-type i8042's. Unfortunately
* SiS screwed up and their 5597 doesn't support the LOOP command even
* though it has an AUX port.
*/ */
param = 0x5a; param = 0x5a;
if (i8042_command(&param, I8042_CMD_AUX_LOOP) || param != 0xa5) if (i8042_command(&param, I8042_CMD_AUX_LOOP) || param != 0xa5) {
return -1;
/* /*
* External connection test - filters out AT-soldered PS/2 i8042's * External connection test - filters out AT-soldered PS/2 i8042's
* 0x00 - no error, 0x01-0x03 - clock/data stuck, 0xff - general error * 0x00 - no error, 0x01-0x03 - clock/data stuck, 0xff - general error
* 0xfa - no error on some notebooks which ignore the spec * 0xfa - no error on some notebooks which ignore the spec
* We ignore general error, since some chips report it even under normal * Because it's common for chipsets to return error on perfectly functioning
* operation. * AUX ports, we test for this only when the LOOP command failed.
*/ */
if (i8042_command(&param, I8042_CMD_AUX_TEST) if (i8042_command(&param, I8042_CMD_AUX_TEST)
|| (param && param != 0xfa && param != 0xff)) || (param && param != 0xfa && param != 0xff))
return -1; return -1;
}
/* /*
* Bit assignment test - filters out PS/2 i8042's in AT mode * Bit assignment test - filters out PS/2 i8042's in AT mode
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment