Commit ea024870 authored by Anton Arapov's avatar Anton Arapov Committed by Oleg Nesterov

uretprobes: Introduce uprobe_consumer->ret_handler()

Enclose return probes implementation, introduce ->ret_handler() and update
existing code to rely on ->handler() *and* ->ret_handler() for uprobe and
uretprobe respectively.
Signed-off-by: default avatarAnton Arapov <anton@redhat.com>
Acked-by: default avatarSrikar Dronamraju <srikar@linux.vnet.ibm.com>
Signed-off-by: default avatarOleg Nesterov <oleg@redhat.com>
parent 3f47107c
...@@ -46,6 +46,9 @@ enum uprobe_filter_ctx { ...@@ -46,6 +46,9 @@ enum uprobe_filter_ctx {
struct uprobe_consumer { struct uprobe_consumer {
int (*handler)(struct uprobe_consumer *self, struct pt_regs *regs); int (*handler)(struct uprobe_consumer *self, struct pt_regs *regs);
int (*ret_handler)(struct uprobe_consumer *self,
unsigned long func,
struct pt_regs *regs);
bool (*filter)(struct uprobe_consumer *self, bool (*filter)(struct uprobe_consumer *self,
enum uprobe_filter_ctx ctx, enum uprobe_filter_ctx ctx,
struct mm_struct *mm); struct mm_struct *mm);
......
...@@ -838,6 +838,14 @@ int uprobe_register(struct inode *inode, loff_t offset, struct uprobe_consumer * ...@@ -838,6 +838,14 @@ int uprobe_register(struct inode *inode, loff_t offset, struct uprobe_consumer *
struct uprobe *uprobe; struct uprobe *uprobe;
int ret; int ret;
/* Uprobe must have at least one set consumer */
if (!uc->handler && !uc->ret_handler)
return -EINVAL;
/* TODO: Implement return probes */
if (uc->ret_handler)
return -ENOSYS;
/* Racy, just to catch the obvious mistakes */ /* Racy, just to catch the obvious mistakes */
if (offset > i_size_read(inode)) if (offset > i_size_read(inode))
return -EINVAL; return -EINVAL;
...@@ -1497,10 +1505,13 @@ static void handler_chain(struct uprobe *uprobe, struct pt_regs *regs) ...@@ -1497,10 +1505,13 @@ static void handler_chain(struct uprobe *uprobe, struct pt_regs *regs)
down_read(&uprobe->register_rwsem); down_read(&uprobe->register_rwsem);
for (uc = uprobe->consumers; uc; uc = uc->next) { for (uc = uprobe->consumers; uc; uc = uc->next) {
int rc = uc->handler(uc, regs); int rc = 0;
WARN(rc & ~UPROBE_HANDLER_MASK, if (uc->handler) {
"bad rc=0x%x from %pf()\n", rc, uc->handler); rc = uc->handler(uc, regs);
WARN(rc & ~UPROBE_HANDLER_MASK,
"bad rc=0x%x from %pf()\n", rc, uc->handler);
}
remove &= rc; remove &= rc;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment