Commit ea09f457 authored by Dave Jones's avatar Dave Jones Committed by Adrian Bunk

[ALSA] fix usbmixer double kfree

snd_ctl_add() kfree's the kcontrol already if we fail there,
so this driver is currently doing a double kfree.

Coverity bug #959
Signed-off-by: default avatarDave Jones <davej@redhat.com>
Signed-off-by: default avatarAdrian Bunk <bunk@stusta.de>
parent 7819bfbb
...@@ -434,7 +434,6 @@ static int add_control_to_empty(struct mixer_build *state, struct snd_kcontrol * ...@@ -434,7 +434,6 @@ static int add_control_to_empty(struct mixer_build *state, struct snd_kcontrol *
kctl->id.index++; kctl->id.index++;
if ((err = snd_ctl_add(state->chip->card, kctl)) < 0) { if ((err = snd_ctl_add(state->chip->card, kctl)) < 0) {
snd_printd(KERN_ERR "cannot add control (err = %d)\n", err); snd_printd(KERN_ERR "cannot add control (err = %d)\n", err);
snd_ctl_free_one(kctl);
return err; return err;
} }
cval->elem_id = &kctl->id; cval->elem_id = &kctl->id;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment