Commit ea5c7f1b authored by Will Deacon's avatar Will Deacon Committed by Thomas Gleixner

tick/broadcast: Program wakeup timer when entering idle if required

When configuring the broadcast timer on entry to and exit from deep idle
states, prefer a per-CPU wakeup timer if one exists.

On entry to idle, stop the tick device and transfer the next event into
the oneshot wakeup device, which will serve as the wakeup from idle. To
avoid the overhead of additional hardware accesses on exit from idle,
leave the timer armed and treat the inevitable interrupt as a (possibly
spurious) tick event.
Signed-off-by: default avatarWill Deacon <will@kernel.org>
Signed-off-by: default avatarThomas Gleixner <tglx@linutronix.de>
Link: https://lore.kernel.org/r/20210524221818.15850-5-will@kernel.org
parent c94a8537
...@@ -96,6 +96,15 @@ static struct clock_event_device *tick_get_oneshot_wakeup_device(int cpu) ...@@ -96,6 +96,15 @@ static struct clock_event_device *tick_get_oneshot_wakeup_device(int cpu)
return per_cpu(tick_oneshot_wakeup_device, cpu); return per_cpu(tick_oneshot_wakeup_device, cpu);
} }
static void tick_oneshot_wakeup_handler(struct clock_event_device *wd)
{
/*
* If we woke up early and the tick was reprogrammed in the
* meantime then this may be spurious but harmless.
*/
tick_receive_broadcast();
}
static bool tick_set_oneshot_wakeup_device(struct clock_event_device *newdev, static bool tick_set_oneshot_wakeup_device(struct clock_event_device *newdev,
int cpu) int cpu)
{ {
...@@ -121,6 +130,7 @@ static bool tick_set_oneshot_wakeup_device(struct clock_event_device *newdev, ...@@ -121,6 +130,7 @@ static bool tick_set_oneshot_wakeup_device(struct clock_event_device *newdev,
if (!try_module_get(newdev->owner)) if (!try_module_get(newdev->owner))
return false; return false;
newdev->event_handler = tick_oneshot_wakeup_handler;
set_device: set_device:
clockevents_exchange_device(curdev, newdev); clockevents_exchange_device(curdev, newdev);
per_cpu(tick_oneshot_wakeup_device, cpu) = newdev; per_cpu(tick_oneshot_wakeup_device, cpu) = newdev;
...@@ -909,16 +919,48 @@ static int ___tick_broadcast_oneshot_control(enum tick_broadcast_state state, ...@@ -909,16 +919,48 @@ static int ___tick_broadcast_oneshot_control(enum tick_broadcast_state state,
return ret; return ret;
} }
static int tick_oneshot_wakeup_control(enum tick_broadcast_state state,
struct tick_device *td,
int cpu)
{
struct clock_event_device *dev, *wd;
dev = td->evtdev;
if (td->mode != TICKDEV_MODE_ONESHOT)
return -EINVAL;
wd = tick_get_oneshot_wakeup_device(cpu);
if (!wd)
return -ENODEV;
switch (state) {
case TICK_BROADCAST_ENTER:
clockevents_switch_state(dev, CLOCK_EVT_STATE_ONESHOT_STOPPED);
clockevents_switch_state(wd, CLOCK_EVT_STATE_ONESHOT);
clockevents_program_event(wd, dev->next_event, 1);
break;
case TICK_BROADCAST_EXIT:
/* We may have transitioned to oneshot mode while idle */
if (clockevent_get_state(wd) != CLOCK_EVT_STATE_ONESHOT)
return -ENODEV;
}
return 0;
}
int __tick_broadcast_oneshot_control(enum tick_broadcast_state state) int __tick_broadcast_oneshot_control(enum tick_broadcast_state state)
{ {
struct tick_device *td = this_cpu_ptr(&tick_cpu_device); struct tick_device *td = this_cpu_ptr(&tick_cpu_device);
int cpu = smp_processor_id(); int cpu = smp_processor_id();
if (!tick_oneshot_wakeup_control(state, td, cpu))
return 0;
if (tick_broadcast_device.evtdev) if (tick_broadcast_device.evtdev)
return ___tick_broadcast_oneshot_control(state, td, cpu); return ___tick_broadcast_oneshot_control(state, td, cpu);
/* /*
* If there is no broadcast device, tell the caller not * If there is no broadcast or wakeup device, tell the caller not
* to go into deep idle. * to go into deep idle.
*/ */
return -EBUSY; return -EBUSY;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment