Skip to content

L
linux
Commit ea5e150a authored by Ville Syrjälä's avatar Ville Syrjälä
Browse files
Options

drm/i915: Tweak BIOS fb reuse check 

Currently we assume that we bind the BIOS fb exactly into the same
ggtt address where the BIOS left it. That is about to change, and
in order to keep intel_reuse_initial_plane_obj() working as intended
we need to compare the original ggtt offset (called 'base' here)
as opposed to the actual vma ggtt offset we selected. Otherwise
the first plane could change the ggtt offset, and then subsequent
planes would no longer notice that they are in fact using the same
ggtt offset that the first plane was already using. Thus the reuse
check will fail and we proceed to turn off these subsequent planes.

TODO: would probably make more sense to do the pure readout first
for all the planes, then check for fb reuse, and only then proceed
to pin the object into the final location in the ggtt...

v2: "fix" xe
Reviewed-by: default avatarAndrzej Hajda <andrzej.hajda@intel.com>
Tested-by: default avatarPaz Zcharya <pazz@chromium.org>
Signed-off-by: default avatarVille Syrjälä <ville.syrjala@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20240202224340.30647-15-ville.syrjala@linux.intel.comAcked-by: default avatarLucas De Marchi <lucas.demarchi@intel.com>
parent f1ee98cf
Hide whitespace changes
Inline Side-by-side
Showing with 35 additions and 28 deletions
drivers/gpu/drm/i915/display/intel_plane_initial.c
View file @ ea5e150a
...@@ -13,20 +13,21 @@ ...@@ -13,20 +13,21 @@
#include "intel_plane_initial.h" #include "intel_plane_initial.h"
static bool static bool
intel_reuse_initial_plane_obj(struct drm_i915_private *i915, intel_reuse_initial_plane_obj(struct intel_crtc *this,
const struct intel_initial_plane_config *plane_config, const struct intel_initial_plane_config plane_configs[],
struct drm_framebuffer **fb, struct drm_framebuffer **fb,
struct i915_vma **vma) struct i915_vma **vma)
{ {
struct drm_i915_private *i915 = to_i915(this->base.dev);
struct intel_crtc *crtc; struct intel_crtc *crtc;
for_each_intel_crtc(&i915->drm, crtc) { for_each_intel_crtc(&i915->drm, crtc) {
struct intel_crtc_state *crtc_state =
to_intel_crtc_state(crtc->base.state);
struct intel_plane *plane = struct intel_plane *plane =
to_intel_plane(crtc->base.primary); to_intel_plane(crtc->base.primary);
struct intel_plane_state *plane_state = const struct intel_plane_state *plane_state =
to_intel_plane_state(plane->base.state); to_intel_plane_state(plane->base.state);
const struct intel_crtc_state *crtc_state =
to_intel_crtc_state(crtc->base.state);
if (!crtc_state->uapi.active) if (!crtc_state->uapi.active)
continue; continue;
...@@ -34,7 +35,7 @@ intel_reuse_initial_plane_obj(struct drm_i915_private *i915, ...@@ -34,7 +35,7 @@ intel_reuse_initial_plane_obj(struct drm_i915_private *i915,
if (!plane_state->ggtt_vma) if (!plane_state->ggtt_vma)
continue; continue;
if (intel_plane_ggtt_offset(plane_state) == plane_config->base) { if (plane_configs[this->pipe].base == plane_configs[crtc->pipe].base) {
*fb = plane_state->hw.fb; *fb = plane_state->hw.fb;
*vma = plane_state->ggtt_vma; *vma = plane_state->ggtt_vma;
return true; return true;
...@@ -265,10 +266,11 @@ intel_alloc_initial_plane_obj(struct intel_crtc *crtc, ...@@ -265,10 +266,11 @@ intel_alloc_initial_plane_obj(struct intel_crtc *crtc,
static void static void
intel_find_initial_plane_obj(struct intel_crtc *crtc, intel_find_initial_plane_obj(struct intel_crtc *crtc,
struct intel_initial_plane_config *plane_config) struct intel_initial_plane_config plane_configs[])
{ {
struct drm_device *dev = crtc->base.dev; struct drm_i915_private *dev_priv = to_i915(crtc->base.dev);
struct drm_i915_private *dev_priv = to_i915(dev); struct intel_initial_plane_config *plane_config =
&plane_configs[crtc->pipe];
struct intel_plane *plane = struct intel_plane *plane =
to_intel_plane(crtc->base.primary); to_intel_plane(crtc->base.primary);
struct intel_plane_state *plane_state = struct intel_plane_state *plane_state =
...@@ -294,7 +296,7 @@ intel_find_initial_plane_obj(struct intel_crtc *crtc, ...@@ -294,7 +296,7 @@ intel_find_initial_plane_obj(struct intel_crtc *crtc,
* Failed to alloc the obj, check to see if we should share * Failed to alloc the obj, check to see if we should share
* an fb with another CRTC instead * an fb with another CRTC instead
*/ */
if (intel_reuse_initial_plane_obj(dev_priv, plane_config, &fb, &vma)) if (intel_reuse_initial_plane_obj(crtc, plane_configs, &fb, &vma))
goto valid_fb; goto valid_fb;
/* /*
...@@ -359,10 +361,12 @@ static void plane_config_fini(struct intel_initial_plane_config *plane_config) ...@@ -359,10 +361,12 @@ static void plane_config_fini(struct intel_initial_plane_config *plane_config)
void intel_initial_plane_config(struct drm_i915_private *i915) void intel_initial_plane_config(struct drm_i915_private *i915)
{ {
struct intel_initial_plane_config plane_configs[I915_MAX_PIPES] = {};
struct intel_crtc *crtc; struct intel_crtc *crtc;
for_each_intel_crtc(&i915->drm, crtc) { for_each_intel_crtc(&i915->drm, crtc) {
struct intel_initial_plane_config plane_config = {}; struct intel_initial_plane_config *plane_config =
&plane_configs[crtc->pipe];
if (!to_intel_crtc_state(crtc->base.state)->uapi.active) if (!to_intel_crtc_state(crtc->base.state)->uapi.active)
continue; continue;
...@@ -374,14 +378,14 @@ void intel_initial_plane_config(struct drm_i915_private *i915) ...@@ -374,14 +378,14 @@ void intel_initial_plane_config(struct drm_i915_private *i915)
* can even allow for smooth boot transitions if the BIOS * can even allow for smooth boot transitions if the BIOS
* fb is large enough for the active pipe configuration. * fb is large enough for the active pipe configuration.
*/ */
i915->display.funcs.display->get_initial_plane_config(crtc, &plane_config); i915->display.funcs.display->get_initial_plane_config(crtc, plane_config);
/* /*
* If the fb is shared between multiple heads, we'll * If the fb is shared between multiple heads, we'll
* just get the first one. * just get the first one.
*/ */
intel_find_initial_plane_obj(crtc, &plane_config); intel_find_initial_plane_obj(crtc, plane_configs);
plane_config_fini(&plane_config); plane_config_fini(plane_config);
} }
} }
drivers/gpu/drm/xe/display/xe_plane_initial.c
View file @ ea5e150a
...@@ -18,19 +18,20 @@ ...@@ -18,19 +18,20 @@
#include "intel_plane_initial.h" #include "intel_plane_initial.h"
static bool static bool
intel_reuse_initial_plane_obj(struct drm_i915_private *i915, intel_reuse_initial_plane_obj(struct intel_crtc *this,
const struct intel_initial_plane_config *plane_config, const struct intel_initial_plane_config plane_configs[],
struct drm_framebuffer **fb) struct drm_framebuffer **fb)
{ {
struct drm_i915_private *i915 = to_i915(this->base.dev);
struct intel_crtc *crtc; struct intel_crtc *crtc;
for_each_intel_crtc(&i915->drm, crtc) { for_each_intel_crtc(&i915->drm, crtc) {
struct intel_crtc_state *crtc_state =
to_intel_crtc_state(crtc->base.state);
struct intel_plane *plane = struct intel_plane *plane =
to_intel_plane(crtc->base.primary); to_intel_plane(crtc->base.primary);
struct intel_plane_state *plane_state = const struct intel_plane_state *plane_state =
to_intel_plane_state(plane->base.state); to_intel_plane_state(plane->base.state);
const struct intel_crtc_state *crtc_state =
to_intel_crtc_state(crtc->base.state);
if (!crtc_state->uapi.active) if (!crtc_state->uapi.active)
continue; continue;
...@@ -38,7 +39,7 @@ intel_reuse_initial_plane_obj(struct drm_i915_private *i915, ...@@ -38,7 +39,7 @@ intel_reuse_initial_plane_obj(struct drm_i915_private *i915,
if (!plane_state->ggtt_vma) if (!plane_state->ggtt_vma)
continue; continue;
if (intel_plane_ggtt_offset(plane_state) == plane_config->base) { if (plane_configs[this->pipe].base == plane_configs[crtc->pipe].base) {
*fb = plane_state->hw.fb; *fb = plane_state->hw.fb;
return true; return true;
} }
...@@ -178,10 +179,10 @@ intel_alloc_initial_plane_obj(struct intel_crtc *crtc, ...@@ -178,10 +179,10 @@ intel_alloc_initial_plane_obj(struct intel_crtc *crtc,
static void static void
intel_find_initial_plane_obj(struct intel_crtc *crtc, intel_find_initial_plane_obj(struct intel_crtc *crtc,
struct intel_initial_plane_config *plane_config) struct intel_initial_plane_config plane_configs[])
{ {
struct drm_device *dev = crtc->base.dev; struct intel_initial_plane_config *plane_config =
struct drm_i915_private *dev_priv = to_i915(dev); &plane_configs[crtc->pipe];
struct intel_plane *plane = struct intel_plane *plane =
to_intel_plane(crtc->base.primary); to_intel_plane(crtc->base.primary);
struct intel_plane_state *plane_state = struct intel_plane_state *plane_state =
...@@ -201,7 +202,7 @@ intel_find_initial_plane_obj(struct intel_crtc *crtc, ...@@ -201,7 +202,7 @@ intel_find_initial_plane_obj(struct intel_crtc *crtc,
if (intel_alloc_initial_plane_obj(crtc, plane_config)) if (intel_alloc_initial_plane_obj(crtc, plane_config))
fb = &plane_config->fb->base; fb = &plane_config->fb->base;
else if (!intel_reuse_initial_plane_obj(dev_priv, plane_config, &fb)) else if (!intel_reuse_initial_plane_obj(crtc, plane_configs, &fb))
goto nofb; goto nofb;
plane_state->uapi.rotation = plane_config->rotation; plane_state->uapi.rotation = plane_config->rotation;
...@@ -269,10 +270,12 @@ static void plane_config_fini(struct intel_initial_plane_config *plane_config) ...@@ -269,10 +270,12 @@ static void plane_config_fini(struct intel_initial_plane_config *plane_config)
void intel_initial_plane_config(struct drm_i915_private *i915) void intel_initial_plane_config(struct drm_i915_private *i915)
{ {
struct intel_initial_plane_config plane_configs[I915_MAX_PIPES] = {};
struct intel_crtc *crtc; struct intel_crtc *crtc;
for_each_intel_crtc(&i915->drm, crtc) { for_each_intel_crtc(&i915->drm, crtc) {
struct intel_initial_plane_config plane_config = {}; struct intel_initial_plane_config *plane_config =
&plane_configs[crtc->pipe];
if (!to_intel_crtc_state(crtc->base.state)->uapi.active) if (!to_intel_crtc_state(crtc->base.state)->uapi.active)
continue; continue;
...@@ -284,14 +287,14 @@ void intel_initial_plane_config(struct drm_i915_private *i915) ...@@ -284,14 +287,14 @@ void intel_initial_plane_config(struct drm_i915_private *i915)
* can even allow for smooth boot transitions if the BIOS * can even allow for smooth boot transitions if the BIOS
* fb is large enough for the active pipe configuration. * fb is large enough for the active pipe configuration.
*/ */
i915->display.funcs.display->get_initial_plane_config(crtc, &plane_config); i915->display.funcs.display->get_initial_plane_config(crtc, plane_config);
/* /*
* If the fb is shared between multiple heads, we'll * If the fb is shared between multiple heads, we'll
* just get the first one. * just get the first one.
*/ */
intel_find_initial_plane_obj(crtc, &plane_config); intel_find_initial_plane_obj(crtc, plane_configs);
plane_config_fini(&plane_config); plane_config_fini(plane_config);
} }
} }
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7