Commit eb357cba authored by Michał Kępień's avatar Michał Kępień Committed by Darren Hart

platform/x86: fujitsu-laptop: decrease indentation in acpi_fujitsu_hotkey_notify()

acpi_fujitsu_hotkey_notify() is pretty deeply nested, which hurts
readability.  Strip off one level of indentation by returning early when
the event code supplied as argument is not ACPI_FUJITSU_NOTIFY_CODE1.
Signed-off-by: default avatarMichał Kępień <kernel@kempniu.pl>
Acked-by: default avatarJonathan Woithe <jwoithe@just42.net>
Signed-off-by: default avatarDarren Hart <dvhart@linux.intel.com>
parent 5c461e8e
...@@ -1044,98 +1044,96 @@ static void acpi_fujitsu_hotkey_notify(struct acpi_device *device, u32 event) ...@@ -1044,98 +1044,96 @@ static void acpi_fujitsu_hotkey_notify(struct acpi_device *device, u32 event)
input = fujitsu_hotkey->input; input = fujitsu_hotkey->input;
if (event != ACPI_FUJITSU_NOTIFY_CODE1) {
keycode = KEY_UNKNOWN;
vdbg_printk(FUJLAPTOP_DBG_WARN,
"Unsupported event [0x%x]\n", event);
input_report_key(input, keycode, 1);
input_sync(input);
input_report_key(input, keycode, 0);
input_sync(input);
return;
}
if (fujitsu_hotkey->rfkill_supported) if (fujitsu_hotkey->rfkill_supported)
fujitsu_hotkey->rfkill_state = fujitsu_hotkey->rfkill_state =
call_fext_func(FUNC_RFKILL, 0x4, 0x0, 0x0); call_fext_func(FUNC_RFKILL, 0x4, 0x0, 0x0);
switch (event) { i = 0;
case ACPI_FUJITSU_NOTIFY_CODE1: while ((irb =
i = 0; call_fext_func(FUNC_BUTTONS, 0x1, 0x0, 0x0)) != 0
while ((irb = && (i++) < MAX_HOTKEY_RINGBUFFER_SIZE) {
call_fext_func(FUNC_BUTTONS, 0x1, 0x0, 0x0)) != 0 switch (irb & 0x4ff) {
&& (i++) < MAX_HOTKEY_RINGBUFFER_SIZE) { case KEY1_CODE:
switch (irb & 0x4ff) { keycode = fujitsu->keycode1;
case KEY1_CODE: break;
keycode = fujitsu->keycode1; case KEY2_CODE:
break; keycode = fujitsu->keycode2;
case KEY2_CODE: break;
keycode = fujitsu->keycode2; case KEY3_CODE:
break; keycode = fujitsu->keycode3;
case KEY3_CODE: break;
keycode = fujitsu->keycode3; case KEY4_CODE:
break; keycode = fujitsu->keycode4;
case KEY4_CODE: break;
keycode = fujitsu->keycode4; case KEY5_CODE:
break; keycode = fujitsu->keycode5;
case KEY5_CODE: break;
keycode = fujitsu->keycode5; case 0:
break; keycode = 0;
case 0: break;
keycode = 0; default:
break; vdbg_printk(FUJLAPTOP_DBG_WARN,
default: "Unknown GIRB result [%x]\n", irb);
keycode = -1;
break;
}
if (keycode > 0) {
vdbg_printk(FUJLAPTOP_DBG_TRACE,
"Push keycode into ringbuffer [%d]\n",
keycode);
status = kfifo_in_locked(&fujitsu_hotkey->fifo,
(unsigned char *)&keycode,
sizeof(keycode),
&fujitsu_hotkey->fifo_lock);
if (status != sizeof(keycode)) {
vdbg_printk(FUJLAPTOP_DBG_WARN, vdbg_printk(FUJLAPTOP_DBG_WARN,
"Unknown GIRB result [%x]\n", irb); "Could not push keycode [0x%x]\n",
keycode = -1; keycode);
break; } else {
input_report_key(input, keycode, 1);
input_sync(input);
} }
if (keycode > 0) { } else if (keycode == 0) {
while ((status =
kfifo_out_locked(
&fujitsu_hotkey->fifo,
(unsigned char *) &keycode_r,
sizeof(keycode_r),
&fujitsu_hotkey->fifo_lock))
== sizeof(keycode_r)) {
input_report_key(input, keycode_r, 0);
input_sync(input);
vdbg_printk(FUJLAPTOP_DBG_TRACE, vdbg_printk(FUJLAPTOP_DBG_TRACE,
"Push keycode into ringbuffer [%d]\n", "Pop keycode from ringbuffer [%d]\n",
keycode); keycode_r);
status = kfifo_in_locked(&fujitsu_hotkey->fifo,
(unsigned char *)&keycode,
sizeof(keycode),
&fujitsu_hotkey->fifo_lock);
if (status != sizeof(keycode)) {
vdbg_printk(FUJLAPTOP_DBG_WARN,
"Could not push keycode [0x%x]\n",
keycode);
} else {
input_report_key(input, keycode, 1);
input_sync(input);
}
} else if (keycode == 0) {
while ((status =
kfifo_out_locked(
&fujitsu_hotkey->fifo,
(unsigned char *) &keycode_r,
sizeof(keycode_r),
&fujitsu_hotkey->fifo_lock))
== sizeof(keycode_r)) {
input_report_key(input, keycode_r, 0);
input_sync(input);
vdbg_printk(FUJLAPTOP_DBG_TRACE,
"Pop keycode from ringbuffer [%d]\n",
keycode_r);
}
} }
} }
}
/* On some models (first seen on the Skylake-based Lifebook /* On some models (first seen on the Skylake-based Lifebook
* E736/E746/E756), the touchpad toggle hotkey (Fn+F4) is * E736/E746/E756), the touchpad toggle hotkey (Fn+F4) is
* handled in software; its state is queried using FUNC_RFKILL * handled in software; its state is queried using FUNC_RFKILL
*/ */
if ((fujitsu_hotkey->rfkill_supported & BIT(26)) && if ((fujitsu_hotkey->rfkill_supported & BIT(26)) &&
(call_fext_func(FUNC_RFKILL, 0x1, 0x0, 0x0) & BIT(26))) { (call_fext_func(FUNC_RFKILL, 0x1, 0x0, 0x0) & BIT(26))) {
keycode = KEY_TOUCHPAD_TOGGLE; keycode = KEY_TOUCHPAD_TOGGLE;
input_report_key(input, keycode, 1);
input_sync(input);
input_report_key(input, keycode, 0);
input_sync(input);
}
break;
default:
keycode = KEY_UNKNOWN;
vdbg_printk(FUJLAPTOP_DBG_WARN,
"Unsupported event [0x%x]\n", event);
input_report_key(input, keycode, 1); input_report_key(input, keycode, 1);
input_sync(input); input_sync(input);
input_report_key(input, keycode, 0); input_report_key(input, keycode, 0);
input_sync(input); input_sync(input);
break;
} }
} }
/* Initialization */ /* Initialization */
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment